8000 PEP 678: Clarify how the notes tuple is updated and when it is copied by Zac-HD · Pull Request #2377 · python/peps · GitHub
[go: up one dir, main page]
Skip to content

PEP 678: Clarify how the notes tuple is updated and when it is copied #2377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 3, 2022
Merged

PEP 678: Clarify how the notes tuple is updated and when it is copied #2377

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
23296de
PEP 678: clarify internals and heading
Zac-HD Mar 2, 2022
ab5f093
PEP 678: omit impl details
Zac-HD Mar 2, 2022
7c28ab4
PEP 678: clarify rejected idea
Zac-HD Mar 2, 2022
2491278
PEP 678: link cross-reference
Zac-HD Mar 2, 2022
0a20986
PEP 678: final details update
Zac-HD Mar 3, 2022
0d150fa
Apply suggestions from code review
Zac-HD Mar 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
PEP 678: clarify internals and heading
  • Loading branch information
@Zac-HD
Zac-HD committed Mar 2, 2022
commit 23296de73eaa0a977a1e327f4096cc229fadc1bc
12 changes: 6 additions & 6 deletions pep-0678.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,10 +140,10 @@ are collecting multiple exception objects to handle together. [1]_
Specification
=============

``BaseException`` gains a new read-only attribute ``__notes__``, an initially
empty tuple, and a new method ``.add_note(note: str)``. ``note`` is added to
the exception's notes, which appear in the standard traceback after the
exception string. A ``TypeError`` is raised if ``note`` is not a string.
``BaseException`` gains a new new method ``.add_note(note: str)``. Notes are
exposed as a tuple via the read-only attribute ``__notes__``, which is backed
by an internal list, and appear in the standard traceback after the exception
string. ``.add_note()`` raises ``TypeError`` if ``note`` is not a string.

``del err.__notes__`` clears the contents of the ``__notes__`` attribute,
leaving it an empty tuple as if ``.add_note()`` had never been called. This
Expand Down Expand Up @@ -319,8 +319,8 @@ proposed ``__notes__`` semantics, but this would be rarely and inconsistently
applicable.


Store notes in ``ExceptionGroup``\ s
------------------------------------
Store notes in ``ExceptionGroup``\ s, but not other ``Exception``\ s
--------------------------------------------------------------------
Initial discussions proposed making a more focussed change by thinking about
how to associate messages with the nested exceptions in ``ExceptionGroup`` s,
such as a list of notes or mapping of exceptions to notes. However, this would
Expand Down
0