8000 Support code highlighting by ofek · Pull Request #1577 · python/peps · GitHub
[go: up one dir, main page]
Skip to content

Support code highlighting #1577

New issue

Have 8000 a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 23, 2021
Merged

Support code highlighting #1577

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
292633e
Support code highlighting
ofek Jun 2, 2021
a5e2137
address
ofek Jun 19, 2021
7419229
Merge branch 'master' into highlight
ofek Jun 19, 2021
33037b5
pin dependencies to latest minor release
ofek Jun 19, 2021
f64924b
just set minimum dependency versions
ofek Jun 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
- name: Install dependencies
run: |
python -m pip install -U pip
python -m pip install -U docutils
python -m pip install -r requirements.txt

- name: Build
run: make -j$(nproc)
Expand Down
5 changes: 3 additions & 2 deletions requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# Requirements for building PEPs with Sphinx
sphinx >= 3.5
docutils >= 0.16
Pygments >= 2.9.0
Sphinx >= 4.0.2
docutils >= 0.17.1

Copy link
Member
@AA-Turner AA-Turner Jun 19, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only question I'd have is if better to pin to compatible releases or all future? (~= vs >=) - historically been unpinned so I think that means the latest release has always been used.

(but I am not best placed to make this call, as no idea if e.g. previously there have been breaking changes to PEP rendering due to dependency changes, or the risk appetite for this in the future vs new features that may or may not be used)

A

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, changed it back

# For RSS
feedgen >= 0.9.0 # For RSS feed
0