8000 Modernize packaging a bit by bluetech · Pull Request #38 · python/mypy_extensions · GitHub
[go: up one dir, main page]
Skip to content

Modernize packaging a bit #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Modernize packaging a bit #38

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
780aa14
Modernize packaging a bit
bluetech Jul 7, 2023
aad9410
Move setuptools config from setup.cfg with pyproject.toml
bluetech Jul 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Modernize packaging a bit 
Adding pyproject.toml allows the package to be installed using PEP517
instead of legacy `setup.py install` method. At least pip says so in a
warning when installing without the `wheel` package available.

Change setup.py to setup.cfg (using a script[0]) because setup.py is out
of fashion these days.

Remove MANIFEST.ini since LICENSE is implied[1].

[0] https://github.com/gvalkov/setuptools-py2cfg
[1] https://setuptools.pypa.io/en/latest/references/keywords.html#keyword-license-files
  • Loading branch information
@bluetech
bluetech committed Jul 7, 2023
commit 780aa14615559010e52f128a62324b4f16c2eb3f
1 change: 0 additions & 1 deletion MANIFEST.in
View file
Open in desktop

This file was deleted.

3 changes: 3 additions & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
[build-system]
requires = ["setuptools"]
build-backend = "setuptools.build_meta"
32 changes: 30 additions & 2 deletions setup.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,30 @@
[bdist_wheel]
universal=0
[metadata]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might as well put this config in pyproject.toml?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have python 3.5 installed, but I suspect it won't work with it. I'll try getting py3.5 and check it though.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can drop 3.5, 3.6 and 3.7 support

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hauntsaninja great, that might help. I'll send a PR to do this first.

name = mypy_extensions
version = 1.0.0-dev
author = The mypy developers
author_email = jukka.lehtosalo@iki.fi
license = MIT License
description = Type system extensions for programs checked with the mypy type checker.
url = https://github.com/python/mypy_extensions
long_description = Mypy Extensions
===============

The "mypy_extensions" module defines extensions to the standard "typing" module
that are supported by the mypy type checker and the mypyc compiler.

classifiers =
Development Status :: 5 - Production/Stable
Environment :: Console
Intended Audience :: Developers
License :: OSI Approved :: MIT License
Programming Language :: Python :: 3
Programming Language :: Python :: 3.7
Programming Language :: Python :: 3.8
Programming Language :: Python :: 3.9
Programming Language :: Python :: 3.10
Programming Language :: Python :: 3.11
Topic :: Software Development

[options]
py_modules = mypy_extensions
python_requires = >=3.7
39 changes: 0 additions & 39 deletions setup.py
View file
Open in desktop

This file was deleted.

0