add node_modules back to default exclusion

python · JukkaL · Feb 10, 2021 · Jan 29, 2021 · Jan 29, 2021 · Jan 29, 2021
commit cb0917d28042891f72c80b987425b8f88d51573e
diff --git a/docs/source/command_line.rst b/docs/source/command_line.rst
@@ -57,7 +57,7 @@ for full details, see :ref:`running-mypy`.
 
     For instance, to avoid discovering any files named `setup.py` you could
     pass ``--exclude '/setup.py$'``. Similarly, you can ignore discovering
-    directories with a given name by e.g. ``--exclude /node_modules/`` or
+    directories with a given name by e.g. ``--exclude /build/`` or
     those matching a subpath with ``--exclude /project/vendor/``.
 
     Note that this flag only affects recursive discovery, that is, when mypy is
@@ -66,10 +66,11 @@ for full details, see :ref:`running-mypy`.
     instance, ``mypy --exclude '/setup.py$' but_still_check/setup.py``.
 
     Note that mypy will never recursively discover files and directories named
-    "site-packages" or "__pycache__" or those whose name starts with a period,
-    exactly as ``--exclude '/(site-packages|__pycache__|\..*)$'`` would.
-    Mypy will also never recursively discover files with extensions other than
-    ``.py`` or ``.pyi``.
+    "site-packages", "node_modules" or "__pycache__", or those whose name starts
+    with a period, exactly as ``--exclude
+    '/(site-packages|node_modules|__pycache__|\..*)$'`` would. Mypy will also
+    never recursively discover files with extensions other than ``.py`` or
+    ``.pyi``.
 
 
 Optional arguments

diff --git a/mypy/find_sources.py b/mypy/find_sources.py
@@ -105,7 +105,7 @@ def find_sources_in_dir(self, path: str) -> List[BuildSource]:
         names = sorted(self.fscache.listdir(path), key=keyfunc)
         for name in names:
             # Skip certain names altogether
-            if name in ("__pycache__", "site-packages") or name.startswith("."):
+            if name in ("__pycache__", "site-packages", "node_modules") or name.startswith("."):
                 continue
             subpath = os.path.join(path, name)
 

diff --git a/mypy/modulefinder.py b/mypy/modulefinder.py
@@ -444,7 +444,7 @@ def find_modules_recursive(self, module: str) -> List[BuildSource]:
         names = sorted(self.fscache.listdir(package_path))
         for name in names:
             # Skip certain names altogether
-            if name in ("__pycache__", "site-packages") or name.startswith("."):
+            if name in ("__pycache__", "site-packages", "node_modules") or name.startswith("."):
                 continue
             subpath = os.path.join(package_path, name)