8000 Emphasise that users probably want --follow-imports=normal by hauntsaninja · Pull Request #9955 · python/mypy · GitHub
[go: up one dir, main page]
Skip to content

Emphasise that users probably want --follow-imports=normal #9955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 24, 2021
Merged

Emphasise that users probably want --follow-imports=normal #9955

merged 1 commit into from
Jan 24, 2021

Conversation

hauntsaninja
Copy link
Collaborator

For whatever reason, these options get misused a lot and cause a lot of
problems. #9954 is only the latest in a long history of
misunderstanding.

I speculate that this is because of a) the bad legacy of flake8-mypy,
b) people confusing it with ignore_missing_imports

Emphasise that users probably want --follow-imports=normal
fc59213 
For whatever reason, these options get misused a lot and cause a lot of
problems. python#9954 is only the latest in a long history of
misunderstanding.

I speculate that this is because of a) the bad legacy of flake8-mypy,
b) people confusing it with ignore_missing_imports
gvanrossum
gvanrossum approved these changes Jan 24, 2021
View reviewed changes
Copy link
Member
@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. As you probably know that flag was primarily designed for a transitional stage of introducing mypy at Dropbox gradually.

@hauntsaninja hauntsaninja merged commit 37d29fc into python:master Jan 24, 2021
@hauntsaninja hauntsaninja deleted the docs branch January 24, 2021 20:55
@JelleZijlstra JelleZijlstra mentioned this pull request Jan 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hauntsaninja @gvanrossum
0