8000 Predict enum value type for unknown member names. by mgilson · Pull Request #9443 · python/mypy · GitHub
[go: up one dir, main page]
Skip to content

Predict enum value type for unknown member names. #9443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Sep 17, 2020
Merged

Predict enum value type for unknown member names. #9443

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
fa67a31
Predict enum value type for unknown member names.
mgilson-argo Sep 15, 2020
077d3e7
Fix a typo. Squash before merging.
mgilson-argo Sep 15, 2020
e861117
Get enum-value inference to work with auto.
mgilson-argo Sep 16, 2020
db16871
Fix flake8 complaint.
mgilson-argo Sep 16, 2020
bfee76d
Fixup the unit-tests.
mgilson-argo Sep 16, 2020
b3653d7
Remove some unused fixtures.
mgilson-argo Sep 16, 2020
f1adaf5
Make the self-test happy.
mgilson-argo Sep 16, 2020
22c1474
Invert logic for inferring with value-type in presence of auto.
mgilson-argo Sep 17, 2020
aae9de3
Change a ValueError to an `assert` for type collapsing.
mgilson-argo Sep 17, 2020
d392d05
Shorten some names and drop a branch or two.
mgilson-argo Sep 17, 2020
050fdc2
Get my conditional right ... I think ...
mgilson-argo Sep 17, 2020
5fa5a93
Fix the fixture application.
mgilson-argo Sep 17, 2020
5b8baa9
Stop using `next` for now.
mgilson-argo Sep 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Change a ValueError to an assert for type collapsing.
  • Loading branch information
@mgilson-argo
mgilson-argo committed Sep 17, 2020
commit aae9de37a29e44d1e5dd965a6bfcd223624bf45e
3 changes: 1 addition & 2 deletions mypy/plugins/enums.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,7 @@ def _infer_value_type_with_auto_fallback(
if not (isinstance(proper_type, Instance) or
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and!

proper_type.type.fullname != 'enum.auto'):
return proper_type
if not isinstance(ctx.type, Instance):
raise ValueError("An incorrect ctx.type was passed.")
assert isinstance(ctx.type, Instance), 'An incorrect ctx.type was passed.'
info = ctx.type.type
# Find the first _generate_next_value_ on the mro. We need to know
# if it is `Enum` because `Enum` types say that the return-value of
Expand Down
0