8000 Update typeshed to fix TextIOWrapper constructor by Zeletochoy · Pull Request #8965 · python/mypy · GitHub
[go: up one dir, main page]
Skip to content

Update typeshed to fix TextIOWrapper constructor #8965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 12, 2020
Merged

Update typeshed to fix TextIOWrapper constructor #8965

merged 3 commits into from
Jun 12, 2020

Conversation

Zeletochoy
Copy link
Contributor

Currently it doesn't accept ZipFile.open()'s output and fails with
error: Argument 1 to "TextIOWrapper" has incompatible type "IO[bytes]"; expected "BinaryIO"

That was fixed in python/typeshed@3058bec

Zeletochoy added 3 commits June 8, 2020 15:19
@Zeletochoy
Update typeshed to fix TextIOWrapper constructor
f8ff389 
Currently it doesn't accept ZipFile.open()'s output and fails with
error: Argument 1 to "TextIOWrapper" has incompatible type "IO[bytes]"; expected "BinaryIO"

That was fixed in python/typeshed@3058bec
@Zeletochoy
Check for None before calling lru_cache'd get_site_packages_dirs
0bd34be
@Zeletochoy
Specify key for sorting BasicBlocks
def4980
@Hexcles Hexcles mentioned this pull request Jun 8, 2020
Merged
ilevkivskyi
ilevkivskyi approved these changes Jun 12, 2020
View reviewed changes
Copy link
Member
@ilevkivskyi ilevkivskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG!

@ilevkivskyi ilevkivskyi merged commit 84bcb25 into python:master Jun 12, 2020
@Zeletochoy Zeletochoy deleted the update-typeshed-textiowrapper branch June 15, 2020 01:18
This was referenced Oct 9, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilevkivskyi ilevkivskyi ilevkivskyi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Zeletochoy @ilevkivskyi
0