8000 stubtest: add tests by hauntsaninja · Pull Request #8380 · python/mypy · GitHub
[go: up one dir, main page]

Skip to content

stubtest: add tests #8380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Feb 13, 2020
Merged
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
stubtest: fix module level variables missing at runtime
Dumb mistake causing false negatives, mainly seems to surface a lot of
platform differences
  • Loading branch information
hauntsaninja committed Feb 11, 2020
commit ea3f83fa866d59d76400df502bdfbff8182cfdbc
2 changes: 1 addition & 1 deletion mypy/stubtest.py
Original file line number Diff line number Diff line change
Expand Up @@ -655,7 +655,7 @@ def verify_var(
) -> Iterator[Error]:
if isinstance(runtime, Missing):
# Don't always yield an error here, because we often can't find instance variables
if len(object_path) <= 1:
if len(object_path) <= 2:
yield Error(object_path, "is not present at runtime", stub, runtime)
return

Expand Down
0