8000 DRAFT: Returning TypedDict for dataclasses.asdict by syastrov · Pull Request #8339 · python/mypy · GitHub
[go: up one dir, main page]
Skip to content

DRAFT: Returning TypedDict for dataclasses.asdict #8339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 10 commits into from
Closed

DRAFT: Returning TypedDict for dataclasses.asdict #8339

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
ce446f4
Implement support for returning TypedDict for dataclasses.asdict
syastrov Jan 21, 2020
0ed29c6
Add draft of test for recursive asdict.
syastrov Jan 28, 2020
05a554c
dataclasses.asdict: Handle list/tuple/dicts/namedtuples recursively.
syastrov Feb 8, 2020
9330542
Test that List[Any] works.
syastrov Feb 8, 2020
e1c3d13
dataclasses.asdict: Handle default_factory. Work on NamedTuple test/s…
syastrov Feb 11, 2020
12a644f
asdict: Support unions.
syastrov Feb 11, 2020
c26d6d7
asdict: produce an error when recursion detected. cleanup.
syastrov Feb 12, 2020
0111e36
asdict: Support subclasses of list/dict (test missing for dict).
syastrov Feb 12, 2020
a5bd093
asdict: Small cleanup
syastrov Feb 17, 2020
1396945
asdict: For now, handle subtypes of list/dict by converting them to i…
syastrov Feb 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
asdict: Small cleanup
  • Loading branch information
@syastrov
syastrov committed Feb 17, 2020
commit a5bd093d0709a8074474579528ce40fc35bf7854
2 changes: 1 addition & 1 deletion mypy/plugins/dataclasses.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -451,7 +451,7 @@ def _type_asdict_inner(typ: Type, seen_dataclasses: FrozenSet[str]) -> Type:
# Note: Would be nicer to fallback to default_return_type, but that is Any (due to overloads?)
return api.named_generic_type('builtins.dict', [api.named_generic_type('builtins.str', []),
AnyType(TypeOfAny.implementation_artifact)])
seen_dataclasses |= frozenset([info.fullname])
seen_dataclasses |= {info.fullname}
attrs = info.metadata['dataclass']['attributes']
fields = OrderedDict() # type: OrderedDict[str, Type]
for data in attrs:
Expand Down
0