8000 Add plugin to typecheck functools.total_ordering by aecay · Pull Request #7848 · python/mypy · GitHub
[go: up one dir, main page]
Skip to content

Add plugin to typecheck functools.total_ordering #7848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

Add plugin to typecheck functools.total_ordering #7848

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b9cb7d5
Add plugin to typecheck functools.total_ordering
aecay Nov 1, 2019
00ab9b3
Count __eq__ etc methods from superclasses when validating total_orde…
aecay Nov 1, 2019
e1f7142
Warn if __eq__ is inherited from object
aecay Nov 2, 2019
d412c64
Make it typecheck
aecay Nov 2, 2019
69d0b9a
Fix flake8 warnings
aecay Nov 2, 2019
1fa4248
Use type comment for 3.5 compatibility
aecay Nov 2, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Use type comment for 3.5 compatibility
  • Loading branch information
@aecay
aecay committed Nov 2, 2019
commit 1fa4248441f68622d71a1cc736aa636cfaa8ba2f
2 changes: 1 addition & 1 deletion mypy/plugins/total_ordering.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@


def _validate_total_ordering(ctx: ClassDefContext) -> None:
names: Dict[str, str] = dict()
names = dict() # type: Dict[str, str]
for info in ctx.cls.info.mro:
for name in info.names:
if name not in names:
Expand Down
0