8000 Add support for future.utils.with_metaclass by chadrik · Pull Request #7210 · python/mypy · GitHub
[go: up one dir, main page]
Skip to content

Add support for future.utils.with_metaclass #7210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 11, 2019
Merged

Add support for future.utils.with_metaclass #7210

merged 1 commit into from
Oct 11, 2019

Conversation

chadrik
Copy link
Contributor
@chadrik chadrik commented Jul 14, 2019 •
edited by ilevkivskyi
Loading

This util function has the same signature and basic behavior as six.with_metaclass.

Fixes #7193.

emmatyping
emmatyping approved these changes Jul 14, 2019
View reviewed changes
Copy link
Member
@emmatyping emmatyping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A test might be good, but otherwise LGTM.

@chadrik
Copy link
Contributor Author
chadrik commented Jul 14, 2019

A test might be good, but otherwise LGTM.

Ah yeah, I missed the tests for six.with_metaclass. I'll just copy those.

@chadrik
Copy link
Contributor Author
chadrik commented Jul 15, 2019

So this is going to require stubs for future, which is going to be pretty complex, since there are a lot of very ambiguous cases to solve for, like backports of python3-compatible builtins like dict and list. I'll check back when it's ready.

@JelleZijlstra
Copy link
Member

For the purposes of mypy tests, you can probably put a basic stub in mypy/test-data somewhere with just what you need.

@ilevkivskyi
Copy link
Member

There is also a merge conflict now.

@chadrik
Copy link
Contributor Author
chadrik commented Aug 9, 2019 via email

@chadrik chadrik mentioned this pull request Aug 28, 2019
Closed
@chadrik
Add support for future|past.utils.with_metaclass
2721ae4 
Same function signature and basic behavior as six.with_metaclass
@chadrik chadrik force-pushed the future_with_metaclass branch from 27b07de to 2721ae4 Compare October 10, 2019 23:16
@chadrik
Copy link
Contributor Author
chadrik commented Oct 11, 2019

Added tests. This should be all ready to go!

ilevkivskyi
ilevkivskyi approved these changes Oct 11, 2019
View reviewed changes
Copy link
Member
@ilevkivskyi ilevkivskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TBH, this is a bit too much tests :-) Anyway, LGTM!

@ilevkivskyi ilevkivskyi merged commit d607245 into python:master Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emmatyping emmatyping emmatyping approved these changes

@ilevkivskyi ilevkivskyi ilevkivskyi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for future.utils.with_metaclass
4 participants
@chadrik @JelleZijlstra @ilevkivskyi @emmatyping
0