8000 Suggest trying master branch on crash by emmatyping · Pull Request #6934 · python/mypy · GitHub
[go: up one dir, main page]
Skip to content

Suggest trying master branch on crash #6934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 10, 2019
Merged

Suggest trying master branch on crash #6934

merged 2 commits into from
Jun 10, 2019

Conversation

emmatyping
Copy link
Member

I noticed that several recent crash reports were from people on older mypy versions. I thought it would be good to suggest people try the latest master as that may have needed fixes. Here is a sample of the output:

test.py:5: error: INTERNAL ERROR -- Please try using master
https://mypy.rtfd.io/en/latest/common_issues.html#using-pre-release-mypy
If this crash persists, please report a bug at https://github.com/python/mypy/issues
version: 0.710+dev.bde68e77bc6fd209fce765f3ddcc9cb2b4c43e77.dirty
test.py:5: : note: please use --show-traceback to print a traceback when reporting a bug

I also edited the docs section so the title/link wouldn't be so long.

JukkaL
JukkaL reviewed Jun 5, 2019
View reviewed changes
Copy link
Collaborator
@JukkaL JukkaL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good idea, since many users don't think about trying master. I have some ideas about tweaks to the messages.

@emmatyping
Copy link
Member Author

Hopefully the new wording changes are more in line with what you want.
Here are updated examples of what things look like now:

without --show-traceback

test.py:5: error: INTERNAL ERROR -- Please try using mypy master on Github:
https://mypy.rtfd.io/en/latest/common_issues.html#using-development-mypy-build
If this issue continues with mypy master, please report a bug at https://github.com/python/mypy/issues
version: 0.710+dev.7edc5c91f811468d0e5a4d98e3ea5eac59549698.dirty
test.py:5: : note: please use --show-traceback to print a traceback when reporting a bug

with

test.py:5: error: INTERNAL ERROR -- Please try using mypy master on Github:
https://mypy.rtfd.io/en/latest/common_issues.html#using-development-mypy-build
Please report a bug at https://github.com/python/mypy/issues
version: 0.710+dev.7edc5c91f811468d0e5a4d98e3ea5eac59549698.dirty
Traceback (most recent call last):
... (snip)
test.py:5: : note: use --pdb to drop into pdb

JukkaL
JukkaL approved these changes Jun 10, 2019
View reviewed changes
Copy link
Collaborator
@JukkaL JukkaL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates! This should reduce the amount of duplicate bug reports, which is great.

@JukkaL JukkaL merged commit 2202170 into master Jun 10, 2019
@JelleZijlstra JelleZijlstra deleted the trylatest branch June 10, 2019 15:28
PattenR pushed a commit to PattenR/mypy that referenced this pull request Jun 23, 2019
@emmatyping @PattenR
Suggest trying master branch on crash (python#6934)
a5a21ec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blueyed blueyed blueyed approved these changes

@JukkaL JukkaL JukkaL approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emmatyping @blueyed @JukkaL
0