8000 Add flag to prohibit equality checks between non-overlapping checks by ilevkivskyi · Pull Request #6370 · python/mypy · GitHub
[go: up one dir, main page]
Skip to content

Add flag to prohibit equality checks between non-overlapping checks #6370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Feb 15, 2019
Merged

Add flag to prohibit equality checks between non-overlapping checks #6370

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
4b8855d
Strict equality checks
ilevkivskyi Feb 10, 2019
436be2e
Update test fixtures
ilevkivskyi Feb 10, 2019
400ac32
Fix lint and remaining fixture
ilevkivskyi Feb 10, 2019
d1c4fcf
Copy the fixture instaead
ilevkivskyi Feb 10, 2019
086c225
Fix capitalization
Feb 11, 2019
397c3a2
Address CR
Feb 14, 2019
cad5281
Add corner case Type[...] overlap and update tests
Feb 14, 2019
85f48e3
Improve one test
Feb 14, 2019
91f2563
Update docs w.r.t. new None semantics
Feb 14, 2019
9fa2be7
Fix lint
Feb 14, 2019
b737f2d
Refactor repeating Type[...] checks into a nested function
ilevkivskyi Feb 14, 2019
3cd12d9
Simplify logic; add comments
ilevkivskyi Feb 14, 2019
143db54
Save one more line and instead add a comment
ilevkivskyi Feb 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Improve one test
  • Loading branch information
Ivan Levkivskyi committed Feb 14, 2019
commit 85f48e31b8fed137d9dcf76833a5a1e67aab18af
2 changes: 1 addition & 1 deletion test-data/unit/check-expressions.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2095,7 +2095,7 @@ class D(C): ...
class Bad: ...

subclasses: List[Type[C]]
C in subclasses
object in subclasses
D in subclasses
Bad in subclasses # E: Non-overlapping container check (element type: "Type[Bad]", container item type: "Type[C]")
[builtins fixtures/list.pyi]
Expand Down
0