-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
{{ message }}
Add docs for --namespace-packages #5749
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msullivan
approved these changes
Oct 9, 2018
| Note that this only affects import discovery -- for modules and | ||
| packages explicitly passed on the command line, mypy still | ||
| searches for ``__init__.py[i]`` files in order to determine the | ||
| fully-qualified module/package name. |
There was a problem hiding this comment.
Maybe it would be worth talking about what to do in order to explicitly check code in namespace packages?
There was a problem hiding this comment.
What about things like mypy -m foo.bar if foo is a namespace package? Users may expect it to work, since the module name is explicit. Similarly, what about mypy -p foo if foo is a namespace package?
There was a problem hiding this comment.
Hm, none of those currently work. Maybe they should, but I don't have time to make it work in this release (command line files/modules/packages use an entirely different code path than imported modules). I'll open a new issue.
There was a problem hiding this comment.
mypy -c 'import foo.bar', I suppose?
There was a problem hiding this comment.
Hm, there are still problems with that. I'm not sure why. Will try to look into this before the release goes out.
It might surprise people. Plus PEP 420 only applies to Python 3. If there's demand (and the bugs are shaken out) we can enable it by default for Python 3 in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up for #5691. Should be cherry-picked into the release (#5741). Fixes #5757.