8000 Fine-grained: Don't infer partial types from multiple targets by JukkaL · Pull Request #4553 · python/mypy · GitHub
[go: up one dir, main page]
Skip to content

Fine-grained: Don't infer partial types from multiple targets #4553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Feb 20, 2018
Merged

Fine-grained: Don't infer partial types from multiple targets #4553

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
0c58fef
Initial implementation of requiring "local" partial types
JukkaL Jan 22, 2018
3e62fde
Hide local partial types behind an option
JukkaL Feb 7, 2018
9059894
Set local_partial_types correctly
JukkaL Feb 7, 2018
9d242db
Some refactoring
JukkaL Feb 8, 2018
20a5c54
Add two failing test cases
JukkaL Feb 8, 2018
07599a8
Fix special cases
JukkaL Feb 8, 2018
3f57aae
Fix crash
JukkaL Feb 8, 2018
3cc3ce4
Avoid generating multiple messages from a single error
JukkaL Feb 8, 2018
b165730
Minor tweaks
JukkaL Feb 8, 2018
bf0a9a1
Add test cases
JukkaL Feb 8, 2018
1763a8c
Minor test updates
JukkaL Feb 8, 2018
681f1df
Merge branch 'master' into fine-grained-partial-scope
JukkaL Feb 19, 2018
3f3e4f0
Update based on feedback
JukkaL Feb 19, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add test cases
  • Loading branch information
@JukkaL
JukkaL committed Feb 8, 2018
commit bf0a9a1dcae73061eb148fed31c30e42af5bcc96
18 changes: 18 additions & 0 deletions test-data/unit/check-inference.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2239,3 +2239,21 @@ class A:
self.x = f(p)
f(z for z in p)
[builtins fixtures/list.pyi]

[case testLocalPartialTypesAccessPartialNoneAttribute]
# flags: --local-partial-types
class C:
a = None # E: Need type annotation for 'a'

def f(self, x) -> None:
# TODO: It would be better for the type to be Any here
C.a.y # E: "None" has no attribute "y"

[case testLocalPartialTypesAccessPartialNoneAttribute]
# flags: --local-partial-types
class C:
a = None # E: Need type annotation for 'a'

def f(self, x) -> None:
# TODO: It would be better for the type to be Any here
self.a.y # E: "None" has no attribute "y"
0