Exit with code 2 on blocking errors #4443
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exit with code 2 on blocking errors, while continuing to exit with 1 when there are nonblocking errors. Add test infrastructure. Fixes #2754.
|
(This depends on #4396 because they would otherwise conflict) |
gvanrossum
requested changes
Jan 8, 2018
mypy/test/testcmdline.py
Outdated
| @@ -78,6 +79,7 @@ def test_python_cmdline(testcase: DataDrivenTestCase) -> None: | |||
| path)) | |||
| else: | |||
| out = normalize_error_messages(out) | |||
| out.append('== Return code: {}'.format(result)) | |||
There was a problem hiding this comment.
Hm, this added a lot of noise to a lot of tests. Perhaps only print the return code when it's not equal to not len(out)?
|
Those cases don't add blockers to the errors object, but they raise CompileError directly, which causes us to exit with 2. One of the tests I added checks for this. |
|
Ah, I see. But I'd still like to see fewer tests with different output. |
gvanrossum
approved these changes
Jan 8, 2018
|
Whee! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exit with code 2 on blocking errors, while continuing to exit with 1
when there are nonblocking errors. Add test infrastructure.
Fixes #2754.