10000 Flush error messages incrementally after processing a file by msullivan · Pull Request #4396 · python/mypy · GitHub
[go: up one dir, main page]

Skip to content

Flush error messages incrementally after processing a file #4396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Jan 9, 2018
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Don't use variable type annotations
  • Loading branch information
msullivan committed Jan 4, 2018
commit 059de143442c8b11763dc4a95bac345a294c9df1
4 changes: 2 additions & 2 deletions mypy/test/testerrorstream.py
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,8 @@ def test_error_stream(testcase: DataDrivenTestCase) -> None:
options = Options()
options.show_traceback = True

logged_messages: List[str] = []
real_messages: List[str] = []
logged_messages = [] # type: List[str]
real_messages = [] # type: List[str]

def flush_errors(msgs: List[str], serious: bool, is_real: bool=True) -> None:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be spaces around the = (it's a special case in PEP 8 :-).

if msgs:
Expand Down
0