8000 Flush error messages incrementally after processing a file by msullivan · Pull Request #4396 · python/mypy · GitHub
[go: up one dir, main page]
Skip to content

Flush error messages incrementally after processing a file #4396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Jan 9, 2018
Merged

Flush error messages incrementally after processing a file #4396

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
4b38029
Flush error messages incrementally after processing a file
msullivan Dec 15, 2017
76f945f
Add more tests and stream blocking errors as well
msullivan Dec 21, 2017
310611d
Check for streaming errors matching in testcheck
msullivan Dec 21, 2017
059de14
Don't use variable type annotations
msullivan Jan 2, 2018
c9a5a96
Flush the file buffers after writing for better behavior when wrapped
msullivan Jan 2, 2018
76bb7f8
ditch the decorator
msullivan Jan 3, 2018
5c9abec
Eliminate the indexing
msullivan Jan 3, 2018
844d5ca
Drop plugin part of the test, do test cleanup
msullivan Jan 3, 2018
c9d2355
Remove error_files
msullivan Jan 3, 2018
699ba0b
fix a variable name
msullivan Jan 3, 2018
376982d
Ditch the caching system, run all error aggregation through the callback
msullivan Jan 4, 2018
caa8477
Get rid of the .messages() method
msullivan Jan 4, 2018
92dfc2d
Key errors based on origin file
msullivan Jan 5, 2018
cc64198
Perform various cleanups
msullivan Jan 9, 2018
548078c
update warn_unused_ignores documentation
msullivan Jan 9, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Don't use variable type annotations
  • Loading branch information
@msullivan
msullivan committed Jan 4, 2018
commit 059de143442c8b11763dc4a95bac345a294c9df1
4 changes: 2 additions & 2 deletions mypy/test/testerrorstream.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,8 @@ def test_error_stream(testcase: DataDrivenTestCase) -> None:
options = Options()
options.show_traceback = True

logged_messages: List[str] = []
real_messages: List[str] = []
logged_messages = [] # type: List[str]
real_messages = [] # type: List[str]

def flush_errors(msgs: List[str], serious: bool, is_real: bool=True) -> None:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be spaces around the = (it's a special case in PEP 8 :-).

if msgs:
Expand Down
0