-
-
Notifications
You must be signed in to change notification settings - Fork 3k
Remove myunit #4369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Remove myunit #4369
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
2ece9a0
remove myunit
elazarg ca12acf
remove unused helpers
elazarg 57a2599
revert ROADMAP, return TODO and assert_equal
elazarg 108cdbf
Merge branch 'master' into remove-myunit
elazarg 919f7c4
Merge branch 'master' into remove-myunit
emmatyping ff8ef0a
Add blank line
elazarg 4d7cdc2
Merge branch 'master' into remove-myunit
elazarg b9c47a7
undo removal of empty line
elazarg 0cb5798
fix testerrorstream
elazarg 491bac9
Follow review
elazarg 83b6c85
Merge remote-tracking branch 'upstream/master' into remove-myunit
elazarg a2ebf80
ArgSuite: do not test options.config_file
elazarg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
remove unused helpers
- Loading branch information
commit ca12acf2454e48513d3189d92ea3fbc3c68bcb0c
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add comment about
assert_true
andassert_false
being redundant (we could just use the assert statement).