8000 Support TypedDicts with missing keys (total=False) by JukkaL · Pull Request #3558 · python/mypy · GitHub
[go: up one dir, main page]
Skip to content

Support TypedDicts with missing keys (total=False) #3558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Jun 23, 2017
Merged

Support TypedDicts with missing keys (total=False) #3558

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
ccfc4ad
Basic support for TypedDicts with missing keys (total=False)
JukkaL Jun 14, 2017
44f53a9
Support get(key, {}) and fix construction of partial typed dict
JukkaL Jun 15, 2017
6bb872e
Fix subtyping of non-total typed dicts
JukkaL Jun 15, 2017
4df39fc
Fix join with non-total typed dict
JukkaL Jun 15, 2017
39f0d38
Fix meet with non-total typed dicts
JukkaL Jun 15, 2017
7e042b8
Add serialization test case
JukkaL Jun 15, 2017
981023a
Support TypedDict total keyword argument with class syntax
JukkaL Jun 16, 2017
6223d2a
Attempt to fix Python 3.3
JukkaL Jun 16, 2017
5ecafb2
Add minimal runtime `total` support to mypy_extensions
JukkaL Jun 16, 2017
0d16271
Merge branch 'master' into typeddict-total
JukkaL Jun 19, 2017
1c068e0
Fix tests on pre-3.6 Python and improve introspection
JukkaL Jun 19, 2017
4429ce1
Fix lint
JukkaL Jun 19, 2017
1c2d327
Merge branch 'master' into typeddict-total
JukkaL Jun 21, 2017
5359a98
Fix problems caused by merge
JukkaL Jun 21, 2017
a09c5b9
Allow td['key'] even if td is not total
JukkaL Jun 21, 2017
059bc21
Fix lint
JukkaL Jun 21, 2017
b47857e
Add test case
JukkaL Jun 21, 2017
6b922b5
Merge branch 'master' into typeddict-total
JukkaL Jun 22, 2017
31b6696
Address review feedback
JukkaL Jun 22, 2017
d32fd68
Update comment
JukkaL Jun 22, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Attempt to fix Python 3.3
  • Loading branch information
@JukkaL
JukkaL committed Jun 16, 2017
commit 6223d2a06a6a74b03d38b24d11d696b65c81a782
2 changes: 1 addition & 1 deletion mypy/checkexpr.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,7 +292,7 @@ def check_typeddict_call_with_dict(self, callee: TypedDictType,
def check_typeddict_call_with_kwargs(self, callee: TypedDictType,
kwargs: 'OrderedDict[str, Expression]',
context: Context) -> Type:
if not (callee.required_keys <= kwargs.keys() <= callee.items.keys()):
if not (callee.required_keys <= set(kwargs.keys()) <= set(callee.items.keys())):
callee_item_names = [key for key in callee.items.keys()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Naming these two variables expected_xxx and actual_xxx (matching the error message call below) would help in understanding what they mean.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A good idea -- done.

if key in callee.required_keys or key in kwargs.keys()]
kwargs_item_names = kwargs.keys()
Expand Down
0