10000 Simplify and tighten type aliases by ilevkivskyi · Pull Request #3524 · python/mypy · GitHub
[go: up one dir, main page]
Skip to content

Simplify and tighten type aliases #3524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Jul 7, 2017
Merged

Simplify and tighten type aliases #3524

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
d07259a
Start reworking type aliases
ilevkivskyi Jun 10, 2017
34de9ae
Fix another alias issue
ilevkivskyi Jun 10, 2017
6765a08
Add some tests
ilevkivskyi Jun 10, 2017
8dc40d6
Prohibit reassigning aliases
ilevkivskyi Jun 10, 2017
b76dafc
Merge upstream
ilevkivskyi Jun 22, 2017
aa3831e
Merge remote-tracking branch 'upstream/master' into rework-type-aliases
ilevkivskyi Jun 22, 2017
50056c4
Factor out common code, fix runtime aliases and deserialization; add …
ilevkivskyi Jun 22, 2017
b2212dd
Fix typo
ilevkivskyi Jun 22, 2017
598a511
Don't create aliases at function scope, create variables instead
Jun 29, 2017
4d8cef1
Merge branch 'rework-type-aliases' of https://github.com/ilevkivskyi/…
Jun 29, 2017
f90dabf
Fix broken merge
Jun 29, 2017
7970238
Merge branch 'master' into rework-type-aliases
ilevkivskyi Jul 4, 2017
8c35be0
Fix strict-optional self-test :-)
Jul 4, 2017
91e2be4
Merge branch 'master' into rework-type-aliases
ilevkivskyi Jul 5, 2017
5cc1953
First part of review comments
ilevkivskyi Jul 6, 2017
7e7c1b7
Second part of review comments
< 10000 span class="description"> ilevkivskyi Jul 6, 2017
efe6342
Minor fix; reduce nesting in check_and_set_up_type_alias
ilevkivskyi Jul 6, 2017
91bda84
Better type on error; shorten docstring; minor refactoring
ilevkivskyi Jul 7, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix typo
  • Loading branch information
@ilevkivskyi
ilevkivskyi committed Jun 22, 2017
commit b2212dd51889b251a438cca349a1834b652bb38f
2 changes: 1 addition & 1 deletion mypy/fixup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ def visit_symbol_table(self, symtab: SymbolTable) -> None:
value.type_override = stnode.type_override
if not value.type_override and self.quick_and_dirty:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand this -- add a comment. Is there a test case that tests this change?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now I am also not sure it is needed. It was an attempt to fix #3355, but now I have a better idea. I removed this for now, and will make a separate PR later.

value.type_override = Instance(stale_info(), [])
value.alias_tvars = stnode.alias_tvras or []
value.alias_tvars = stnode.alias_tvars or []
elif not self.quick_and_dirty:
assert stnode is not None, "Could not find cross-ref %s" % (cross_ref,)
else:
Expand Down
0