8000 [WIP] Fix crash when joining tuple and NamedTuple by pkch · Pull Request #3129 · python/mypy · GitHub
[go: up one dir, main page]
Skip to content

[WIP] Fix crash when joining tuple and NamedTuple #3129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 21 commits into from
Closed

[WIP] Fix crash when joining tuple and NamedTuple #3129

Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
a72c71b
Update builtins stub to make test fail when production code fails
pkch Apr 4, 2017
2e90e9f
Fix join of Tuple and NamedTuple
pkch Apr 4, 2017
936bbe6
Fix Tuple behavior
pkch Apr 5, 2017
5810f55
CR fixes
pkch Apr 6, 2017
bc631d9
Merge branch 'master' into namedtuple-join
pkch Apr 6, 2017
865ec24
Type check fix
pkch Apr 6, 2017
a255694
Merge branch 'master' into namedtuple-join
pkch May 1, 2017
a27613a
CR fixes
pkch May 1, 2017
84b8fae
Merge branch 'master' into namedtuple-join
pkch Jun 4, 2017
ea2b1b4
Fix *[Any] -> * in expected error messages
pkch Jun 5, 2017
a230dd9
CR fixes (partial)
pkch Jun 24, 2017
02961f4
Merge branch 'master' into namedtuple-join
pkch Jun 24, 2017
a993ba6
Update error messages
pkch Jun 24, 2017
fb4ce35
Updated typeshed to recent master
pkch Jun 24, 2017
f292ea4
Revert weird change to test output
pkch Jun 25, 2017
52b0c0f
Empty commit to test Travis
pkch Jun 25, 2017
07e7e64
Merge branch 'master' into namedtuple-join
pkch Jul 25, 2017
f991a2b
Fix error message in test
pkch Jul 25, 2017
c1304ba
Revert tuple normalization
pkch Jul 25, 2017
959e6c9
Revert changes to pyi
pkch Jul 25, 2017
8edde23
Make tuple generic in most stubs
pkch Jul 25, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix error message in test
  • Loading branch information
@pkch
pkch committed Jul 25, 2017
commit f991a2b2a30755ecc8c94ec81c85f861c280811c
2 changes: 1 addition & 1 deletion test-data/unit/check-namedtuple.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -415,7 +415,7 @@ b = B._make(['']) # type: B
[case testNamedTupleIncompatibleRedefinition]
from typing import NamedTuple
class Crash(NamedTuple):
count: int # E: Incompatible types in assignment (expression has type "int", base class "tuple" defined the type as Callable[[Tuple[Any, ...], Any], int])
count: int # E: Incompatible types in assignment (expression has type "int", base class "tuple" defined the type as Callable[[tuple, Any], int])
[builtins fixtures/tuple.pyi]

[case testNamedTupleInClassNamespace]
Expand Down
0