8000 Implement async generators (PEP 525) by JelleZijlstra · Pull Request #2711 · python/mypy · GitHub
[go: up one dir, main page]
Skip to content

Implement async generators (PEP 525) #2711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Mar 18, 2017
Merged

Implement async generators (PEP 525) #2711

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
c741a97
asyncgen: progress
JelleZijlstra Jan 17, 2017
4dc62b6
rename is_coroutine_generator -> is_async_generator, implement is_asy…
JelleZijlstra Jan 18, 2017
c64e7fc
working implementation
JelleZijlstra Jan 18, 2017
0117379
fix return types of athrow and aclose, error when async generator ret…
JelleZijlstra Jan 19, 2017
01b50de
use AsyncGenerator from typing
JelleZijlstra Jan 19, 2017
feaf051
remove AsyncGenerator from mypy_extensions
JelleZijlstra Jan 19, 2017
2273ac8
fix lint and make it crash less often on typing without AsyncGenerator
JelleZijlstra Jan 19, 2017
c255d84
address Ivan's comments
JelleZijlstra Mar 18, 2017
facc5ed
fix tests
JelleZijlstra Mar 18, 2017
f193e42
fix obsolete test
JelleZijlstra Mar 18, 2017
dc0206c
add test suggested by Jukka
JelleZijlstra Mar 18, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove AsyncGenerator from mypy_extensions 
Probably not worth it
  • Loading branch information
@JelleZijlstra
JelleZijlstra committed Mar 18, 2017
commit feaf0512833f4be274621135fa79c20de5adb67e
24 changes: 0 additions & 24 deletions extensions/mypy_extensions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,36 +6,12 @@
"""

# NOTE: This module must support Python 2.7 in addition to Python 3.x
__all__ = ['TypedDict', 'AsyncGenerator']

import sys
# _type_check is NOT a part of public typing API, it is used here only to mimic
# the (convenient) behavior of types provided by typing module.
from typing import _type_check # type: ignore

if sys.version_info >= (3, 6):
# if our typing version doesn't have https://github.com/python/typing/pull/346, emulate it
try:
from typing import AsyncGenerator
except ImportError:
import collections
from typing import AsyncIterator, Generic, _generic_new, T_co, T_contra

_AG_base = collections.AsyncGenerator

# need exec because the class keyword arg is a syntax error in 2.7
exec("""
class AsyncGenerator(AsyncIterator[T_co], Generic[T_co, T_contra],
extra=_AG_base):
__slots__ = ()

def __new__(cls, *args, **kwds):
if _geqv(cls, AsyncGenerator):
raise TypeError("Type AsyncGenerator cannot be instantiated; "
"create a subclass instead")
return _generic_new(_AG_base, cls, *args, **kwds)
""")


def _check_fails(cls, other):
try:
Expand Down
2 changes: 1 addition & 1 deletion test-data/unit/lib-stub/mypy_extensions.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
from typing import Dict, Type, TypeVar, AsyncGenerator as AsyncGenerator
from typing import Dict, Type, TypeVar

T = TypeVar('T')

Expand Down
0