-
-
Notifications
You must be signed in to change notification settings - Fork 3k
Allow overloads in source files, not just stubs #2603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
e59f264
Overloads in source files, not just stub files
sixolet bb5fdae
Properties count as overloads too
sixolet ecb5f73
tests and fixes and types and such
sixolet 435751d
Add impl & test for fastparse2
sixolet 7b3c08d
Temporary checkpoint -- most tests pass but not overloads in classes
sixolet 6296587
Partly-programatically modify all non-impl overload tests to be in st…
sixolet 91b1726
Refactor so that overload decides on its impl at semanal time
sixolet dbc770c
Guido comments and polish
sixolet 80fc979
s/cannot/does not/
sixolet 045be3e
Fix windows paths when expanding errors in non-main files
sixolet 95555e6
Another theory about how to make windows paths work
sixolet c12a9fd
It is simpler to have OverloadPart be a union
sixolet 143692a
Merge master
sixolet 04ce906
Many of Guidos comments
sixolet a191620
Test implementation with type variables, and fix the bugs
sixolet b24d2ec
lint
sixolet 9fa66f4
remove extra blank linkes
sixolet c6c6d03
Put is_overload in correct else clause
sixolet File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Properties count as overloads too
- Loading branch information
commit bb5fdae5d7b374cc02a8d0429a37db5eecfd8fb2
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a comment explaining why properties are also considered overloads? Is this just because the same parse tree structure is used to support a sequence of
@property
,@f.getter
and/or@f.deleter
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead I deferred it to semanalysis time, where it belongs