8000 Check deferred nodes after all first passes in an import cycle by gvanrossum · Pull Request #2264 · python/mypy · GitHub
[go: up one dir, main page]
Skip to content

Check deferred nodes after all first passes in an import cycle #2264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Oct 24, 2016
Merged

Check deferred nodes after all first passes in an import cycle #2264

Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
cd22b73
Use a separate TypeChecker per file.
Oct 15, 2016
4bd65c0
Change the TypeChecker toplevel interface.
Oct 16, 2016
9b46001
Do deferred (second) type checker pass after all first passes in an SCC.
Oct 17, 2016
d4d26c6
Add simple tests.
Oct 17, 2016
4afdc13
Fix test failures due to semantic_analysis_only flag.
Oct 17, 2016
be3dfa1
Add TODOs about getting rid of BuildResult and all_types.
Oct 17, 2016
de3a076
Also hide cross-module notes with --hide-error-context
Oct 19, 2016
ed10d6d
Expand docstring for check_first_pass()
Oct 19, 2016
30c84fa
Suppress reveal_type() output when current node is being deferred
Oct 19, 2016
f68a7d4
Add reveal_type() calls to testSymmetricImportCycle*
Oct 19, 2016
fd5bc22
WIP skip deferred queue duplicates
Oct 20, 2016
53f635b
Make it easy to do more than 2 passes
Oct 22, 2016
182059b
Add a test that would require three passes
Oct 22, 2016
981c36e
Make lint happy
Oct 22, 2016
bb5361f
Test case for error reported by pass two
Oct 22, 2016
8abacf1
Test case for deferred decorator
Oct 23, 2016
6aea45a
Explicit test case that reveal_type() shuts up in deferred function f…
Oct 23, 2016
19345a0
Remove print calls
Oct 24, 2016
bb212eb
Remove --hide-error-context from new tests and adjust expected output
Oct 24, 2016
331f845
Add reversed version of testErrorInPassTwo
Oct 24, 2016
d1778da
Make decorator more complicated (both b.deco and a.g are now deferred)
Oct 24, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Suppress reveal_type() output when current node is being deferred
  • Loading branch information
Guido van Rossum committed Oct 24, 2016
commit 30c84fa7e63ebf527f2228af615d9491397a6a8c
3 changes: 2 additions & 1 deletion mypy/checkexpr.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1367,7 +1367,8 @@ def is_valid_cast(self, source_type: Type, target_type: Type) -> bool:
def visit_reveal_type_expr(self, expr: RevealTypeExpr) -> Type:
"""Type check a reveal_type expression."""
revealed_type = self.accept(expr.expr)
self.msg.reveal_type(revealed_type, expr)
if not self.chk.current_node_deferred:
self.msg.reveal_type(revealed_type, expr)
return revealed_type

def visit_type_application(self, tapp: TypeApplication) -> Type:
Expand Down
0