8000 Explicit types for bindables ("Tighten Types" continued) by elazarg · Pull Request #2238 · python/mypy · GitHub
[go: up one dir, main page]
Skip to content

Explicit types for bindables ("Tighten Types" continued) #2238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Mar 27, 2017
Merged

Explicit types for bindables ("Tighten Types" continued) #2238

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
d01d2f1
rename binder api
elazarg Oct 6, 2016
8966207
Merge upstream/master into bindables
elazarg Oct 10, 2016
a99dfcb
Merge remote-tracking branch 'upstream/master' into bindables
elazarg Oct 10, 2016
e742453
update Node->Expression
elazarg Oct 10, 2016
d634539
move literal* to Expression
elazarg Oct 10, 2016
06fe586
make literal_hash an object
elazarg Oct 10, 2016
1f8adb8
Merge remote-tracking branch 'upstream/master' into bindables
elazarg Oct 18, 2016
98167cd
update api call
elazarg Oct 18, 2016
0dab466
fix Key type
elazarg Oct 18, 2016
6f4b29c
remove type: ignore
elazarg Oct 20, 2016
8e9ea44
remove assertion
8000 elazarg Nov 2, 2016
1989243
Merge remote-tracking branch 'upstream/master' into bindables
elazarg Nov 9, 2016
201c744
revert _if_bindable
elazarg Nov 9, 2016
208c16d
make get_declaration a function
elazarg Nov 9, 2016
5f36c72
Merge remote-tracking branch 'upstream/master' into bindables
elazarg Mar 15, 2017
5925fd0
Delete a superfluous line to trigger tests.
gvanrossum Mar 27, 2017
4dfc2c7
Merge remote-tracking branch 'upstream/master' into bindables
elazarg Mar 27, 2017
43e9f03
dodge regression - isinstance(AliasOfTuple)
elazarg Mar 27, 2017
2396458
Merge branch 'bindables' of https://github.com/elazarg/mypy into bind…
elazarg Mar 27, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix Key type
  • Loading branch information
@elazarg
elazarg committed Oct 18, 2016
commit 0dab4661bfba33612e85c9993a226fb7365b7d06
2 changes: 1 addition & 1 deletion mypy/binder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ def put_if_bindable(self, expr: Expression, typ: Type) -> None:
def unreachable(self) -> None:
self.frames[-1].unreachable = True

def get(self, expr: Union[Expression, Var]) -> Type:
def get(self, expr: Expression) -> Type:
return self._get(expr.literal_hash)

def is_unreachable(self) -> bool:
Expand Down
2 changes: 1 addition & 1 deletion mypy/nodes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ class Statement(Node):
class Expression(Node):
"""An expression node."""
literal = LITERAL_NO
literal_hash = None # type: object
literal_hash = None # type: Key


# TODO:
Expand Down
0