8000 Implement most common sys.version_info and sys.platform checks by gvanrossum · Pull Request #1942 · python/mypy · GitHub
[go: up one dir, main page]
Skip to content

Implement most common sys.version_info and sys.platform checks #1942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jul 27, 2016
Merged

Implement most common sys.version_info and sys.platform checks #1942

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
3cbf1b4
Add sys.version_info checks. With some basic tests.
Jul 26, 2016
cea303b
Add tests for negated sys.version checks, and fix the code.
Jul 26, 2016
8816915
More tests for sys.version_info[<slice>]. Found no new bugs (except i…
Jul 26, 2016
4e84874
Add more slicing tests. Fixed a bug one of these found.
Jul 26, 2016
d28d75b
Add sys.platform support (no test yet).
Jul 26, 2016
c70a97d
Add tests for sys.platform. Fix type error. Change rules for sys.vers…
Jul 26, 2016
5eaae5a
Be more careful with win32 platform in crawl.py.
Jul 26, 2016
70bcaea
Add TODOs in response to code review.
Jul 27, 2016
65cf9ac
Add more tests for sys.version_info/platform.
Jul 27, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add tests for negated sys.version checks, and fix the code.
  • Loading branch information
Guido van Rossum committed Jul 27, 2016
commit cea303b0925e9bf1e885e7462f5d2e22fd4c0134
19 changes: 9 additions & 10 deletions mypy/semanal.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2781,21 +2781,20 @@ def infer_if_condition_value(expr: Node, pyversion: Tuple[int, int]) -> int:
if alias.op == 'not':
expr = alias.expr
negated = True
result = TRUTH_VALUE_UNKNOWN
if isinstance(expr, NameExpr):
name = expr.name
elif isinstance(expr, MemberExpr):
name = expr.name
else:
r = consider_sys_version_info(expr, pyversion)
if r != TRUTH_VALUE_UNKNOWN:
return r
result = TRUTH_VALUE_UNKNOWN
if name == 'PY2':
result = ALWAYS_TRUE if pyversion[0] == 2 else ALWAYS_FALSE
elif name == 'PY3':
result = ALWAYS_TRUE if pyversion[0] == 3 else ALWAYS_FALSE
elif name == 'MYPY':
result = ALWAYS_TRUE
result = consider_sys_version_info(expr, pyversion)
if result == TRUTH_VALUE_UNKNOWN:
if name == 'PY2':
result = ALWAYS_TRUE if pyversion[0] == 2 else ALWAYS_FALSE
elif name == 'PY3':
result = ALWAYS_TRUE if pyversion[0] == 3 else ALWAYS_FALSE
elif name == 'MYPY':
result = ALWAYS_TRUE
if negated:
if result == ALWAYS_TRUE:
result = ALWAYS_FALSE
Expand Down
20 changes: 20 additions & 0 deletions test-data/unit/check-unreachable-code.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,3 +131,23 @@ else:
reveal_type(foo()) # E: Revealed type is 'builtins.int'
[builtins fixtures/ops.py]
[out]

[case testSysVersionInfoNegated_python2]
import sys
if not (sys.version_info[0] < 3):
def foo() -> int: return 0
else:
def foo() -> str: return ''
reveal_type(foo()) # E: Revealed type is 'builtins.str'
[builtins_py2 fixtures/ops.py]
[out]

[case testSysVersionInfoNegated]
import sys
if not (sys.version_info[0] < 3):
def foo() -> int: return 0
else:
def foo() -> str: return ''
reveal_type(foo()) # E: Revealed type is 'builtins.int'
[builtins fixtures/ops.py]
[out]
0