8000 Sync typeshed by cdce8p · Pull Request #18880 · python/mypy · GitHub
[go: up one dir, main page]
Skip to content

Sync typeshed #18880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 4, 2025
Merged

Sync typeshed #18880

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2607dcd
Sync typeshed
cdce8p Apr 4, 2025
8afebe1
Partially revert Clean up argparse hacks
cdce8p Feb 15, 2025
9441d4f
Remove use of LiteralString in builtins (#13743)
hauntsaninja Sep 26, 2022
6e11fd1
Revert Remove redundant inheritances from Iterator in builtins
cdce8p Dec 21, 2024
28d03fe
Revert sum literal integer change (#13961)
hauntsaninja Oct 29, 2022
b8d3f70
Revert typeshed ctypes change Since the plugin provides superior type…
AlexWaygood May 1, 2023
55346f6
Remove unused type ignore comment
cdce8p Apr 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Revert sum literal integer change (#13961) 
This is allegedly causing large performance problems, see 13821

typeshed/8231 had zero hits on mypy_primer, so it's not the worst thing
to undo. Patching this in typeshed also feels weird, since there's a
more general soundness issue. If a typevar has a bound or constraint, we
might not want to solve it to a Literal.

If we can confirm the performance regression or fix the unsoundness
within mypy, I might pursue upstreaming this in typeshed.

(Reminder: add this to the sync_typeshed script once merged)
  • Loading branch information
@hauntsaninja @cdce8p
hauntsaninja authored and cdce8p committed Apr 4, 2025
commit 28d03fef8681ce1134f10ce2d73323b0f0d3e10d
2 changes: 1 addition & 1 deletion mypy/typeshed/stdlib/builtins.pyi
75BB
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1699,7 +1699,7 @@ _SupportsSumNoDefaultT = TypeVar("_SupportsSumNoDefaultT", bound=_SupportsSumWit
# without creating many false-positive errors (see #7578).
# Instead, we special-case the most common examples of this: bool and literal integers.
@overload
def sum(iterable: Iterable[bool | _LiteralInteger], /, start: int = 0) -> int: ...
def sum(iterable: Iterable[bool], /, start: int = 0) -> int: ...
@overload
def sum(iterable: Iterable[_SupportsSumNoDefaultT], /) -> _SupportsSumNoDefaultT | Literal[0]: ...
@overload
Expand Down
0