8000 Do not ignore generic type args when checking multiple inheritance compatibility by sterliakov · Pull Request #18270 · python/mypy · GitHub
[go: up one dir, main page]
Skip to content

Do not ignore generic type args when checking multiple inheritance compatibility #18270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 11 commits into from
Closed

Do not ignore generic type args when checking multiple inheritance compatibility #18270

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
e067603
Use bases with substituted generic args when checking multiple inheri…
sterliakov Dec 9, 2024
d9147e0
Ignore transitive errors in multiple inheritance
sterliakov Dec 9, 2024
1960ad9
Sort for fixed messages order
sterliakov Dec 9, 2024
46ec61b
Place inheritance check earlier
sterliakov Dec 9, 2024
6b09c52
Fix the messages order in a test
sterliakov Dec 9, 2024
bdca65a
Try the "typed MRO" approach instead
sterliakov Dec 9, 2024
94bc355
Remove unrelated changes
sterliakov Dec 9, 2024
4710651
Merge remote-tracking branch 'upstream/master' into bugfix/st-multipl…
sterliakov Dec 9, 2024
4323ed7
Final cleanup
sterliakov Dec 10, 2024
f06b2b3
Extract a helper to create typed MRO. Avoid introducing duplicates of…
sterliakov Dec 10, 2024
c81c38d
Include a testcase from review
sterliakov Dec 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Sort for fixed messages order
  • Loading branch information
@sterliakov
sterliakov committed Dec 9, 2024
commit 1960ad9214053a260564c95f3f77b7a3808ac293
3 changes: 2 additions & 1 deletion mypy/checker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2750,7 +2750,8 @@ def check_multiple_inheritance(self, typ: TypeInfo) -> None:
for i, base in enumerate(bases):
# Attributes defined in both the type and base are skipped.
# Normal checks for attribute compatibility should catch any problems elsewhere.
non_overridden_attrs = all_names[i] - typ.names.keys()
# Sort for consistent messages order.
non_overridden_attrs = sorted(all_names[i] - typ.names.keys())
for name in non_overridden_attrs:
if is_private(name):
continue
Expand Down
Loading
0