8000 Sync typeshed by cdce8p · Pull Request #17586 · python/mypy · GitHub
[go: up one dir, main page]
Skip to content

Sync typeshed #17586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 25, 2024
Merged

Sync typeshed #17586

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4326986
Sync typeshed
cdce8p Jul 25, 2024
9b6d28e
Remove use of LiteralString in builtins (#13743)
hauntsaninja Sep 26, 2022
04d1f65
Revert sum literal integer change (#13961)
hauntsaninja Oct 29, 2022
ddc637a
Revert typeshed ctypes change Since the plugin provides superior type…
AlexWaygood May 1, 2023
358df5d
Fix pythoneval tests
cdce8p Jul 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Revert sum literal integer change (#13961) 
This is allegedly causing large performance problems, see 13821

typeshed/8231 had zero hits on mypy_primer, so it's not the worst thing
to undo. Patching this in typeshed also feels weird, since there's a
more general soundness issue. If a typevar has a bound or constraint, we
might not want to solve it to a Literal.

If we can confirm the performance regression or fix the unsoundness
within mypy, I might pursue upstreaming this in typeshed.

(Reminder: add this to the sync_typeshed script once merged)
  • Loading branch information
@hauntsaninja @cdce8p
hauntsaninja authored and cdce8p committed Jul 25, 2024
commit 04d1f65e9cff6226dd3cf2157335e16ffe1feabc
2 changes: 1 addition & 1 deletion mypy/typeshed/stdlib/builtins.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1649,7 +1649,7 @@ _SupportsSumNoDefaultT = TypeVar("_SupportsSumNoDefaultT", bound=_SupportsSumWit
# without creating many false-positive errors (see #7578).
# Instead, we special-case the most common examples of this: bool and literal integers.
@overload
def sum(iterable: Iterable[bool | _LiteralInteger], /, start: int = 0) -> int: ... # type: ignore[overload-overlap]
def sum(iterable: Iterable[bool], /, start: int = 0) -> int: ... # type: ignore[overload-overlap]
@overload
def sum(iterable: Iterable[_SupportsSumNoDefaultT], /) -> _SupportsSumNoDefaultT | Literal[0]: ...
@overload
Expand Down
0