[mypyc] Fix bytes join on Python 3.13 #17527
Conversation
`_PyBytes_Join` is no longer available. Work on mypyc/mypyc#1056.
|
FYI the current plan is to restore |
| if (method == NULL) { | ||
| return NULL; | ||
| } | ||
| PyObject *res = PyObject_VectorcallMethod( |
There was a problem hiding this comment.
This might fail with 3.8. PyObject_VectorcallMethod was provisional there. The leading underscore was removed in 3.9. _PyObject_VectorcallMethod is available as alias in 3.13 for backwards compatibility.
There was a problem hiding this comment.
This is guarded by CPY_3_13_FEATURES so should be fine on that front, right?
There was a problem hiding this comment.
True, missed that. Although now _PyBytes_Join doesn't need to be fixed for 3.13 anymore. See python/cpython#122287
|
|
|
Yes, this is no longer needed on 3.13.0rc1. |
CPython 3.13 no longer has
_PyBytes_Joinor_PyObject_CallMethodIdOneArg.Work on mypyc/mypyc#1056.