8000 stubgen: Preserve simple defaults in function signatures by hamdanal · Pull Request #15355 · python/mypy · GitHub
[go: up one dir, main page]
Skip to content

stubgen: Preserve simple defaults in function signatures #15355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Nov 27, 2023
Merged

stubgen: Preserve simple defaults in function signatures #15355

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
4692138
stubgen: Preserve simple defaults in function signatures
hamdanal Jun 2, 2023
8401f8e
Also add defaults to simple builtin containers
hamdanal Jun 7, 2023
c55605f
Fix self check
hamdanal Jun 7, 2023
8624298
Improve handling of `{**something}` case
hamdanal Jun 27, 2023
69ba241
Merge remote-tracking branch 'upstream/master' into stubgen-defaults
hamdanal Sep 23, 2023
73d5ddd
Merge remote-tracking branch 'upstream/master' into stubgen-defaults
hamdanal Nov 26, 2023
e432e5c
Fix non-ascii bytes and add a test for nan and infinity
hamdanal Nov 26, 2023
d8e7460
Update mypy/stubdoc.py
JelleZijlstra Nov 27, 2023
4011c16
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Improve handling of {**something} case
  • Loading branch information
@hamdanal
hamdanal committed Jun 27, 2023
commit 86242985448a84fe83876368c733088458741892
4 changes: 3 additions & 1 deletion mypy/stubgen.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1465,7 +1465,9 @@ def get_str_default_of_node(self, rvalue: Expression) -> str:
elif isinstance(rvalue, DictExpr):
items_defaults = []
for k, v in rvalue.items:
k_default = self.get_str_default_of_node(k) if k is not None else "..."
if k is None:
break
k_default = self.get_str_default_of_node(k)
v_default = self.get_str_default_of_node(v)
if k_default == "..." or v_default == "...":
break
Expand Down
4 changes: 2 additions & 2 deletions test-data/unit/stubgen.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3356,11 +3356,11 @@ def j(x=[(1, 'a'), (2, 'b')]) -> None: ...
[case testDefaultsOfBuiltinContainersWithNonTrivialContent]
def f(x=(1, u.v), y=(k(),), z=(w,)): ...
def g(x=[1, u.v], y=[k()], z=[w]): ...
def h(x={1: u.v}, y={k(): 2}, z={w: w}): ...
def h(x={1: u.v}, y={k(): 2}, z={m: m}, w={**n}): ...
def i(x={u.v, 2}, y={3, k()}, z={w}): ...

[out]
def f(x=..., y=..., z=...) -> None: ...
def g(x=..., y=..., z=...) -> None: ...
def h(x=..., y=..., z=...) -> None: ...
def h(x=..., y=..., z=..., w=...) -> None: ...
def i(x=..., y=..., z=...) -> None: ...
0