8000 Do not show unused-ignore errors in unreachable code, and make it a real error code by ilevkivskyi · Pull Request #15164 · python/mypy · GitHub
[go: up one dir, main page]
Skip to content

Do not show unused-ignore errors in unreachable code, and make it a real error code #15164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 2, 2023
Merged

Do not show unused-ignore errors in unreachable code, and make it a real error code #15164

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
cec2c71
Better support for unused ignores
ilevkivskyi May 1, 2023
8bf51bd
Normalize decorators; update parse tests
ilevkivskyi May 1, 2023
79c24f4
Add docs; update more tests
ilevkivskyi May 1, 2023
7e7f95f
Improve test
ilevkivskyi May 1, 2023
9ebe5b9
Fix self-check
ilevkivskyi May 1, 2023
7a85018
Move couple tests to 3.8+
ilevkivskyi May 1, 2023
47cb72e
Apply suggestions from code review
JukkaL May 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Improve test
  • Loading branch information
@ilevkivskyi
ilevkivskyi committed May 1, 2023
commit 7e7f95ff1bd2608ee781b4ab01cbdb1a60fca48c
1 change: 1 addition & 0 deletions test-data/unit/check-ignore.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,6 +287,7 @@ try:
import bar # type: ignore[import] # E: Unused "type: ignore" comment
import foobar # type: ignore[unused-ignore]
import barfoo # type: ignore[import,unused-ignore]
import missing # type: ignore[import,unused-ignore]
except Exception:
pass
[file foo.py]
Expand Down
0