Add signature for dataclasses.replace #14849
add fine-grained test
- Loading branch information
commit d71bc21f15a98ad356461d53494a8b9c0ab0f17e
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| [case replace] | ||
| [file model.py] | ||
|
There was a problem hiding this comment. I think this case may be not correct, there should be a top-level section like There was a problem hiding this comment. It's meaningful to import it? I would think mypy goes over all Python files, rather than follow the import chain. e.g. echo > foo.py
echo "a: str = 42" > bar.py
mypy .results in I don't mind adding the There was a problem hiding this comment. I was worried fine-grained test runner doesn't simply check all files (like some other test runners), but I checked the code, and it actually looks OK. |
||
| from dataclasses import dataclass | ||
|
|
||
| @dataclass | ||
| class Model: | ||
| x: int = 0 | ||
| [file replace.py] | ||
| from dataclasses import replace | ||
| from model import Model | ||
|
|
||
| m = Model() | ||
| replace(m, x=42) | ||
|
|
||
| [file model.py.2] | ||
| from dataclasses import dataclass | ||
|
|
||
| @dataclass | ||
| class Model: | ||
| x: str = 'hello' | ||
|
|
||
| [builtins fixtures/dataclasses.pyi] | ||
| [out] | ||
| == | ||
| replace.py:5: error: Argument "x" to "replace" of "Model" has incompatible type "int"; expected "str" | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.