10000 Fix mishandling of typing.Self in attrs generated inits by davfsa · Pull Request #14689 · python/mypy · GitHub
[go: up one dir, main page]
Skip to content

Fix mishandling of typing.Self in attrs generated inits #14689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Fix mishandling of typing.Self in attrs generated inits #14689

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
d6770af
Fix mishandling of typing.Self in attrs generated inits
davfsa Feb 13, 2023
3cc5290
Add missing typehint
davfsa Feb 13, 2023
d76e440
Add missing flag to test
davfsa Feb 14, 2023
6d0615d
De-duplicate code
davfsa Feb 14, 2023
95488d8
Fix typehint
davfsa Feb 14, 2023
c40674b
Merge branch 'master' into bugfix/14685-attrs-self-handling
davfsa Feb 15, 2023
23b9ab5
Add recommended test and fix small bug
davfsa Feb 15, 2023
1dba00a
Revert merging of functions
davfsa Feb 17, 2023
96c5647
Remove un-used imports
davfsa Feb 17, 2023
930e066
Fix typehint
davfsa Feb 17, 2023
c8b343f
Merge branch 'master' into bugfix/14685-attrs-self-handling
davfsa Mar 8, 2023
85a6055
Merge branch 'master' into bugfix/14685-attrs-self-handling
davfsa Mar 15, 2023
c5a1ddc
Merge branch 'master' into bugfix/14685-attrs-self-handling
davfsa Jun 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix typehint
  • Loading branch information
@davfsa
davfsa committed Feb 17, 2023
commit 930e0663e92422faadd6016f6ff58c4ef0efb214
2 changes: 1 addition & 1 deletion mypy/plugins/attrs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ def __init__(
self.context = context
self.init_type = init_type

def expand_type(self, typ: Type, ctx: mypy.plugin.ClassDefContext) -> Type | None:
def expand_type(self, typ: Type | None, ctx: mypy.plugin.ClassDefContext) -> Type | None:
if typ is not None and self.info.self_type is not None:
# In general, it is not safe to call `expand_type()` during semantic analyzis,
# however this plugin is called very late, so all types should be fully ready.
Expand Down
0