8000 Add signature for attr.evolve by ikonst · Pull Request #14526 · python/mypy · GitHub
[go: up one dir, main page]
Skip to content

Add signature for attr.evolve #14526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Mar 6, 2023
Merged

Add signature for attr.evolve #14526

Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
cd832cc
wip
ikonst Jan 26, 2023
64a9e58
more resilient
ikonst Jan 26, 2023
c145514
hmpf
ikonst Jan 26, 2023
3477d2d
wip
ikonst Jan 27, 2023
056ac66
rely on ExpressionChecker.accept :|
ikonst Jan 27, 2023
8b7f3ca
Merge remote-tracking branch 'origin/master' into 2023-01-25-attrs-ev…
ikonst Jan 27, 2023
d976202
handle Any, more tests
ikonst Jan 27, 2023
1bdd315
make type-checker happy
ikonst Jan 27, 2023
4c8138d
nits
ikonst Jan 27, 2023
46026fe
teach fixtures about dict for kwargs
ikonst Jan 27, 2023
2316b06
fix random test failures
ikonst Jan 27, 2023
5148e5f
style
ikonst Jan 27, 2023
cf756d1
improve tests
ikonst Jan 27, 2023
34c8c94
another test
ikonst Jan 27, 2023
87a4c0b
clarify evolve of _what_
ikonst Jan 27, 2023
0976f86
CallableType.copy_modified: arg_name is sequence
ikonst Jan 27, 2023
babf91f
Merge remote-tracking branch 'origin/master' into 2023-01-25-attrs-ev…
ikonst Jan 30, 2023
5443d51
break up evolve tests
ikonst Jan 30, 2023
5271233
Merge remote-tracking branch 'origin/master' into 2023-01-25-attrs-ev…
ikonst Mar 2, 2023
bfcb366
clarify signature
ikonst Mar 3, 2023
0b79cc1
Merge branch 'master' into 2023-01-25-attrs-evolve
ikonst Mar 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
style
  • Loading branch information
@ikonst
ikonst committed Jan 27, 2023
commit 5148e5f16beeeaebdd91111cc8db68c3e5c388f7
6 changes: 2 additions & 4 deletions mypy/plugins/attrs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -937,11 +937,9 @@ def evolve_function_sig_callback(ctx: mypy.plugin.FunctionSigContext) -> Callabl
)
return ctx.default_signature

arg_names = attrs_init_type.arg_names.copy()
arg_names[0] = "inst"
return attrs_init_type.copy_modified(
arg_names=arg_names,
arg_kinds=[ARG_POS] + [ARG_NAMED_OPT] * (len(attrs_init_type.arg_kinds) - 1),
arg_names=["inst"] + attrs_init_type.arg_names[1:],
arg_kinds=[ARG_POS] + [ARG_NAMED_OPT for _ in attrs_init_type.arg_kinds[1:]],
ret_type=inst_type,
name=ctx.default_signature.name,
)
0