8000 [mypyc] Generate faster code for bool comparisons and arithmetic by JukkaL · Pull Request #14489 · python/mypy · GitHub
[go: up one dir, main page]
Skip to content

[mypyc] Generate faster code for bool comparisons and arithmetic #14489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Feb 5, 2023
Merged

[mypyc] Generate faster code for bool comparisons and arithmetic #14489

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
24bc401
[mypyc] Generate faster code for bool comparisons
JukkaL Dec 26, 2022
54655c3
[mypyc] Add test cases for bool binary ops
JukkaL Dec 27, 2022
e4e922d
[mypyc] Speed up unary plus with int/bool operand
JukkaL Dec 27, 2022
1193a13
[mypyc] Generate better code for some mixed bool/native int ops
JukkaL Dec 27, 2022
87a46d5
Add i64 run test
JukkaL Jan 12, 2023
0594fd9
[WIP] Add failing test case
JukkaL Jan 12, 2023
9ec6d4b
Speed up mixed bool/integer comparisons
JukkaL Jan 15, 2023
0f1f3aa
Add run tests for mixed comparisons
JukkaL Jan 21, 2023
61ad1f2
Black
JukkaL Jan 21, 2023
02bae77
Add comment
JukkaL Jan 21, 2023
050c561
Add test case
JukkaL Jan 21, 2023
4c06cc9
Merge branch 'master' into mypyc-bool2
JukkaL Jan 26, 2023
09b925e
Merge branch 'master' into mypyc-bool2
JukkaL Feb 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add run tests for mixed comparisons
  • Loading branch information
@JukkaL
JukkaL committed Jan 21, 2023
commit 0f1f3aaec8645ceddd743c7c870bac5d1055eedf
40 changes: 40 additions & 0 deletions mypyc/test-data/run-bools.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,26 @@ def test_comparisons() -> None:
assert gt(x, y) == (x2 > y2)
assert ge(x, y) == (x2 >= y2)

def eq_mixed(x: bool, y: int) -> bool:
return x == y

def neq_mixed(x: int, y: bool) -> bool:
return x != y

def lt_mixed(x: bool, y: int) -> bool:
return x < y

def gt_mixed(x: int, y: bool) -> bool:
return x > y

def test_mixed_comparisons() -> None:
for x in True, False:
for n in -(1 << 70), -123, 0, 1, 1753, 1 << 70:
assert eq_mixed(x, n) == (int(x) == n)
assert neq_mixed(n, x) == (n != int(x))
assert lt_mixed(x, n) == (int(x) < n)
assert gt_mixed(n, x) == (n > int(x))

def add(x: bool, y: bool) -> int:
return x + y

Expand Down Expand Up @@ -181,3 +201,23 @@ def test_arithmetic_i64() -> None:
for n in -(1 << 62), -123, 0, 1, 1753, 1 << 62:
assert add_mixed_i64(x, n) == int(x) + n
assert sub_mixed_i64(n, x) == n - int(x)

def eq_mixed_i64(x: bool, y: i64) -> bool:
return x == y

def neq_mixed_i64(x: i64, y: bool) -> bool:
return x != y

def lt_mixed_i64(x: bool, y: i64) -> bool:
return x < y

def gt_mixed_i64(x: i64, y: bool) -> bool:
return x > y

def test_mixed_comparisons_i64() -> None:
for x in True, False:
for n in -(1 << 62), -123, 0, 1, 1753, 1 << 62:
assert eq_mixed_i64(x, n) == (int(x) == n)
assert neq_mixed_i64(n, x) == (n != int(x))
assert lt_mixed_i64(x, n) == (int(x) < n)
assert gt_mixed_i64(n, x) == (n > int(x))
0