Allow using super() in methods with self-types #13488
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JelleZijlstra
approved these changes
Aug 23, 2022
AlexWaygood
approved these changes
Aug 23, 2022
Member
There was a problem hiding this comment.
Looks great! Just a minor nit about the is_self_type_like function -- I think the code might be more readable if the parameter is named is_classmethod rather than is_class :-)
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
This comment has been minimized.
This comment has been minimized.
AlexWaygood
approved these changes
Aug 23, 2022
Contributor
|
Diff from mypy_primer, showing the effect of this PR on open source code: prefect (https://github.com/PrefectHQ/prefect)
- src/prefect/orion/utilities/schemas.py:282: error: Argument 2 for "super" not an instance of argument 1
|
dreua
added a commit
to dreua/flatpak-external-data-checker
that referenced
this pull request
Feb 16, 2025
Has been fixed in the meantime: python/mypy#13488
bbhtt
pushed a commit
to flathub-infra/flatpak-external-data-checker
that referenced
this pull request
Feb 17, 2025
Has been fixed in the meantime: python/mypy#13488
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9282
It looks like
super()checking is too strict for methods with self-types. Mypy explicitly allows self-type annotation to be a supertype of current class, so to be consistent, I relax the check forsuper()as well.