8000 Fix for issue #1252. by vakaras · Pull Request #1253 · python/mypy · GitHub
[go: up one dir, main page]
Skip to content

Fix for issue #1252. #1253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 1, 2016
Merged

Fix for issue #1252. #1253

merged 1 commit into from
Mar 1, 2016

Conversation

vakaras
Copy link
Contributor
@vakaras vakaras commented Feb 29, 2016

An attempt to fix #1252.

@gvanrossum
Copy link
Member

So have you tested that it works? I have no objection to this fix, but can you verify that it fixes #1252?

@vakaras
Copy link
Contributor Author
vakaras commented Mar 1, 2016

It seems to fix the problem for the case when mypy is used as a library and bin_dir parameter is omitted. In addition, the correct mypy script can be generated manually by specifying entry-point with None argument:

[buildout]
parts =
  python

# Some black magic to force buildout to use local package instead of
# one from PYPI.
index = .
find-links = /tmp/dist/mypy-lang-0.3.1.tar.gz

[python]
recipe = zc.recipe.egg
interpreter = python
eggs = mypy-lang
scripts =
  mypy_new=mypy
entry-points =
  mypy_new=mypy.main:main
arguments = None

Please find my test log at https://github.com/vakaras/mypy-issue-1252. Please let me know if you think that I should check some other cases, too.

@gvanrossum
Copy link
Member

I think this is fine. I'm going to merge it.

gvanrossum added a commit that referenced this pull request Mar 1, 2016
@gvanrossum
Merge pull request #1253 from vakaras/master
d4a555b 
Fix for issue #1252.
@gvanrossum gvanrossum merged commit d4a555b into python:master Mar 1, 2016
@gvanrossum gvanrossum mentioned this pull request Mar 1, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot find builtins when installed via buildout
2 participants
@vakaras @gvanrossum
0