Use dicts instead of long elif chains for fastparse operator conversion #1248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Lgtm. Disagree with the try/except. --Guido (mobile)
|
|
Yeah, I think this looks cleaner as is. |
ddfisher
added a commit
that referenced
this pull request
Feb 27, 2016
Use dicts instead of long elif chains for fastparse operator conversion
neiljp
added a commit
to neiljp/python-zulip-api
that referenced
this pull request
Nov 15, 2017
neiljp
added a commit
to neiljp/python-zulip-api
that referenced
this pull request
Nov 15, 2017
timabbott
pushed a commit
to zulip/python-zulip-api
that referenced
this pull request
Nov 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per Guido's suggestion on #1218. This is a lot less verbose and slightly faster.