8000 Make mypy tolerant of True/False/__debug__ not being defined in typeshed by ddfisher · Pull Request #1238 · python/mypy · GitHub
[go: up one dir, main page]
Skip to content

Make mypy tolerant of True/False/__debug__ not being defined in typeshed #1238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 24, 2016
Merged

Make mypy tolerant of True/False/__debug__ not being defined in typeshed #1238

merged 3 commits into from
Feb 24, 2016

Conversation

ddfisher
Copy link
Collaborator

This should fix typeshed's CI.

@ddfisher
Make mypy tolerant of True/False/__debug__ not being defined in typeshed
9caa5b4 
They'll be removed in future versions because assigning to them is a
syntax error in Python 3.
@gvanrossum
Copy link
Member

Isn't there something you can do in semanal.py so you won't have to add that dummy "class bool" to all those tests? 25 files touched is a smell...

gvanrossum
gvanrossum reviewed Feb 24, 2016
View reviewed changes
mypy/semanal.py
# Add implicit definition of 'None' to builtins, as we cannot define a
# variable with a None type explicitly.
# Add implicit definition of literals/keywords to builtins, as we
# cannot define a variable with a them explicitly.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grammar "with a them"

@ddfisher ddfisher force-pushed the true-false-tolerance branch from f2a2252 to 2d7ca9f Compare February 24, 2016 20:30
@ddfisher ddfisher force-pushed the true-false-tolerance branch from 2d7ca9f to 21da66b Compare February 24, 2016 20:34
gvanrossum added a commit that referenced this pull request Feb 24, 2016
@gvanrossum
Merge pull request #1238 from ddfisher/true-false-tolerance
35eeebc 
Make mypy tolerant of True/False/__debug__ not being defined in typeshed
@gvanrossum gvanrossum merged commit 35eeebc into python:master Feb 24, 2016
@ddfisher ddfisher mentioned this pull request Feb 25, 2016
Merged
@ddfisher ddfisher deleted the true-false-tolerance branch March 18, 2016 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ddfisher @gvanrossum
0