8000 Fix more crashes in class scoped imports by hauntsaninja · Pull Request #12199 · python/mypy · GitHub
[go: up one dir, main page]
Skip to content

Fix more crashes in class scoped imports #12199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 17, 2022
Merged

Fix more crashes in class scoped imports #12199

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b1f5936
Fix more crashes in class scoped imports
Feb 17, 2022
c5f0e12
type check
Feb 17, 2022
7c2c48d
code review suggestions
Feb 17, 2022
50ef027
fix tests
Feb 17, 2022
3bb511f
fix another mypyc issue
Feb 17, 2022
45d4386
actual mypyc fix
Feb 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
code review suggestions
  • Loading branch information
hauntsaninja committed Feb 17, 2022
commit 7c2c48d62e3e162a39a1f92111fc7f9b679c8a47
44 changes: 34 additions & 10 deletions test-data/unit/check-classes.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7159,22 +7159,42 @@ reveal_type(Foo.mod.foo) # N: Revealed type is "builtins.int"
[file mod.py]
foo: int

[case testClassScopeImportFunctionAlias]
[case testClassScopeImportAlias]
class Foo:
from mod import foo # E: Unsupported class scoped import
bar = foo
from mod import function # E: Unsupported class scoped import
foo = function

from mod import var1
bar = var1

from mod import const_foo
const_bar = const_foo
from mod import var2
baz = var2

from mod import var3
qux = var3

reveal_type(Foo.foo) # N: Revealed type is "Any"
reveal_type(Foo.bar) # N: Revealed type is "Any"
reveal_type(Foo.const_foo) # N: Revealed type is "builtins.int"
reveal_type(Foo.const_bar) # N: Revealed type is "builtins.int"
reveal_type(Foo.function) # N: Revealed type is "Any"

reveal_type(Foo.bar) # N: Revealed type is "builtins.int"
reveal_type(Foo.var1) # N: Revealed type is "builtins.int"

reveal_type(Foo.baz) # N: Revealed type is "mod.C"
reveal_type(Foo.var2) # N: Revealed type is "mod.C"

reveal_type(Foo.qux) # N: Revealed type is "builtins.int"
reveal_type(Foo.var3) # N: Revealed type is "builtins.int"

[file mod.py]
def foo(x: int, y: int) -> int: ...
const_foo: int
def function(x: int, y: int) -> int: ...
var1: int

class C: ...
var2: C

A = int
var3: A


[case testClassScopeImportModuleStar]
class Foo:
Expand Down Expand Up @@ -7249,6 +7269,10 @@ def foo(z: str) -> int: ...
class Foo:
from mod import meth1 # E: Unsupported class scoped import
from mod import meth2 # E: Unsupported class scoped import
from mod import T

reveal_type(Foo.T) # E: Type variable "Foo.T" cannot be used as an expression \
# N: Revealed type is "Any"

[file mod.pyi]
from typing import Any, TypeVar, overload
Expand Down
0