10000 Fix crashes in class scoped imports by hauntsaninja · Pull Request #12023 · python/mypy · GitHub
[go: up one dir, main page]
Skip to content

Fix crashes in class scoped imports #12023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 33 commits into from
Feb 17, 2022
Merged

Fix crashes in class scoped imports #12023

Changes from 1 commit
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
8c61bb3
Fix class scoped imports
Jan 20, 2022
43dfe0d
Merge remote-tracking branch 'upstream/master' into class-scope-import
Jan 20, 2022
c92c172
fix import
Jan 20, 2022
3ebfda3
fix for mypyc
Jan 20, 2022
63f8634
fix more tests
Jan 20, 2022
aa2457e
fix even more tests
Jan 20, 2022
80b6109
mypyc shot in the dark
Jan 20, 2022
6eedcc4
Revert "mypyc shot in the dark"
Jan 20, 2022
7aa37cd
mypyc shot in the dark pt 2
Jan 20, 2022
cc55023
monkeys on a typewriter
Jan 20, 2022
037ce8c
Revert "monkeys on a typewriter"
Jan 20, 2022
2629040
Revert "mypyc shot in the dark pt 2"
Jan 20, 2022
5615fc1
lie to mypyc
Jan 20, 2022
a14004e
wow mypyc
Jan 20, 2022
2119c3d
Fix self binding and improve line number diagnostics
Feb 15, 2022
e09bc02
no more Any
Feb 15, 2022
< 8000 code class="float-right">b93491a
Fix various tests
Feb 15, 2022
7bd60db
make mypyc issues go away
Feb 15, 2022
c467399
more mypyc
Feb 15, 2022
1dc469d
comment
Feb 15, 2022
4f32a01
update comments
Feb 15, 2022
6d02762
fix type checking
Feb 16, 2022
02dd54e
comments
Feb 16, 2022
4523607
more mypyc
Feb 16, 2022
e71c191
i'm stuck in mypyc hell
Feb 16, 2022
d5d80bd
actually do this instead
Feb 16, 2022
13f9e5f
mypyc take 9000
Feb 16, 2022
08ea1a9
another cast
Feb 16, 2022
862b4d8
Merge remote-tracking branch 'upstream/master' into class-scope-import
Feb 16, 2022
6f04070
fffff
Feb 16, 2022
010c936
flake8
Feb 16, 2022
18286eb
remove an assert
Feb 16, 2022
c43756b
add test case suggestion from sobolevn
Feb 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
mypyc shot in the dark
  • Loading branch information
hauntsaninja committed Jan 20, 2022
commit 80b61091c18ee4e336faa0bdc854d31b082ea3b0
5 changes: 4 additions & 1 deletion mypy/semanal.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4788,7 +4788,10 @@ def add_imported_symbol(self,
assert not module_hidden or not module_public

symbol_node: Optional[SymbolNode] = node.node
if self.is_class_scope() and isinstance(symbol_node, (FuncBase, Var)):
if self.is_class_scope() and (
# maybe mypyc likes this code better if we split up isinstance
isinstance(symbol_node, Var) or isinstance(symbol_node, FuncBase)
):
# We construct a new node to represent this symbol and set its `info` attribute
# to `self.type`. Note that imports inside class scope do not produce methods, so
# in all cases constructing a Var gets us the assignment like behaviour we want.
Expand Down
0