Fix error message for dataclasses.field with positional argument #11180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Diff from mypy_primer, showing the effect of this PR on open source code: ignite (https://github.com/pytorch/ignite)
- ignite/engine/deterministic.py:255: error: unused "type: ignore[arg-type, attr-defined]" comment
+ ignite/engine/deterministic.py:255: error: unused "type: ignore" comment
- ignite/engine/deterministic.py:260: error: unused "type: ignore[attr-defined, union-attr]" comment
+ ignite/engine/deterministic.py:260: error: unused "type: ignore" comment
core (https://github.com/home-assistant/core.git)
- homeassistant/components/http/__init__.py:299: error: unused "type: ignore[arg-type, misc]" comment
+ homeassistant/components/http/__init__.py:299: error: unused "type: ignore" comment
aiohttp (https://github.com/aio-libs/aiohttp.git)
- aiohttp/client.py:1063: error: unused "type: ignore[arg-type]" comment
pandas (https://github.com/pandas-dev/pandas.git)
- pandas/core/arrays/_mixins.py:238: error: unused "type: ignore[assignment, type-var]" comment
+ pandas/core/arrays/_mixins.py:238: error: unused "type: ignore" comment
- pandas/core/arrays/datetimelike.py:497: error: unused "type: ignore[arg-type, return-value]" comment
+ pandas/core/arrays/datetimelike.py:497: error: unused "type: ignore" comment
- pandas/core/arrays/string_arrow.py:739: error: unused "type: ignore[arg-type, type-var]" comment
+ pandas/core/arrays/string_arrow.py:739: error: unused "type: ignore" comment
- pandas/core/arrays/string_.py:551: error: unused "type: ignore[arg-type, type-var]" comment
+ pandas/core/arrays/string_.py:551: error: unused "type: ignore" comment
- pandas/io/parsers/base_parser.py:988: error: unused "type: ignore[arg-type, return-value]" comment
+ pandas/io/parsers/base_parser.py:988: error: unused "type: ignore" comment
- pandas/core/reshape/merge.py:2153: error: unused "type: ignore[assignment, union-attr]" comment
+ pandas/core/reshape/merge.py:2153: error: unused "type: ignore" comment
|
|
nice, think I just ran into this. good catch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #10248
The crash due to
dataclasses.fieldwas fixed in the recent PR #11137, but the error message was wrong when positional arguments are used.I update the error message based on the #10248 (comment) (Thanks @JelleZijlstra!)
In
_collect_field_args, I usedCallExpr.arg_kindsto filter only "named" keyword argument, which hopefully is not the wrong usage ofArgKind.I appreciate any feedback and thanks for the review!
Test Plan
Please see
testDataclassFieldWithPositionalArgumentsintest-data/unit/check-dataclasses.test.