[mypyc] Add tests for chr(), ord(), encode() and decode() #10914
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JukkaL
reviewed
Aug 3, 2021
JukkaL
reviewed
Aug 4, 2021
| assert "\U00000394" == '\u0394' | ||
| assert b'\x80abc'.decode("utf-8", "replace") == '\ufffdabc' | ||
| assert b'\x80abc'.decode("utf-8", "backslashreplace") == '\\x80abc' | ||
| assert b'\x80abc'.decode("utf-8", "ignore") == 'abc' |
There was a problem hiding this comment.
A few more ideas: Test decode exception, test latin1, test some different spellings (utf8, utf_8 and Utf-8 all seem to work).
| assert u.encode('ascii', 'xmlcharrefreplace') == b'ꀀabcd޴' | ||
| assert u.encode('ascii', 'backslashreplace') == b'\\ua000abcd\\u07b4' | ||
| assert u.encode('ascii', 'namereplace') == b'\\N{YI SYLLABLE IT}abcd\\u07b4' | ||
| assert 'pythön!'.encode() == b'pyth\xc3\xb6n!' |
There was a problem hiding this comment.
Test latin1, test some different spellings (as above).
|
Also please update the name of the PR to mention |
|
Can you rebase? This should fix CI. |
…de-decode-tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add several run tests:
chr()ord()decode()encode()