Type of conditional expression is object #8074

cjolowicz · 2019-12-04T16:08:12Z

The type of the following conditional expression is object:

s: str = "key=value"
a, b = s.split("=", 1) if "=" in s else ("key", "default")
# main.py:2: error: 'builtins.object' object is not iterable

It should be a union type instead, such as Union[List[str], Tuple[str, str]].

(Note that str.split returns List[str] while the else branch has the type Tuple[str, str].)

This is a follow-up to #3487.

The text was updated successfully, but these errors were encountered:

JukkaL · 2019-12-04T16:48:28Z

Alternatively, inferring Sequence[str] for the conditional expression would help in this case.

Inferring a union type would break backward compatibility. If the fallout is not too bad, it may still make sense.

ilevkivskyi · 2019-12-04T17:08:46Z

Note that a good fix for #4975 may automatically lead to inferring Sequence here.

cjolowicz · 2019-12-05T10:01:20Z

Here is a simpler reproduction:

a, b = [1, 2] if bool() else (1, 2)

intgr · 2020-01-26T18:46:00Z

This issue is addressed in PR #8335.

…8335) For example: * Tuple[int] + Tuple[bool, ...] becomes Tuple[int, ...] * List[int] + Tuple[bool, ...] becomes Sequence[int] Previously Mypy simply punted and returned `object`. This solves the other part of issue #4975. Fixes issue #8074.

emmatyping · 2020-02-03T23:33:26Z

Closing as this was fixed by #8335. Thanks @intgr !

carlosporta · 2021-12-12T02:29:45Z

I am also facing a similar problem.

from typing import Protocol


class Shape(Protocol):
    def area(self) -> str:
        ...


class Circle:
    def area(self) -> str:
        return 'π * r²'


class Square:
    def area(self) -> str:
        return 'w * l'


class ShapeFactory:
    def create(self, shape_type: str) -> Shape:
        return Circle() if shape_type == 'circle' else Square()  # Here

Mypy shows this error message:

error: Incompatible return value type (got "object", expected "Shape")

intgr · 2021-12-12T14:38:29Z

@carlosporta That's a separate issue. Mypy tries to find the common base class of Circle and Square; since those two don't subclass Shape directly, the common base class happens to be object.

carlosporta · 2021-12-12T16:19:37Z

@intgr, I understood what is happening, but this only happens using when using a conditional expression. If I change it to a conditional statement mypy identifies the shape protocol correctly as the return type.< 8000 /p>

This works perfectly, no error messages on mypy:

class ShapeFactory:
    def create(self, shape_type: str) -> Shape:
        if shape_type == 'circle':
            return Circle() 
        else:
            return Square()

Should I create a new issue (Type of conditional expression is object) or am I facing something similar to this issue?

intgr · 2021-12-12T16:39:09Z

@carlosporta I suspect an issue already exists for that, not totally sure. If you don't find one, feel free to open a new one.

But there's a historical background to why the ternary condition works as it does, I believe there's no easy fix: #3487 #5095

carlosporta · 2021-12-12T20:34:47Z

@intgr, I did not find anything related to conditional expression and Protocol, so I created a new issue. If someone goes through a similar problem, here is the issue #11722.

hsghori · 2022-03-01T23:24:30Z

I'm still seeing this issue on mypy==0.910 (which FWICT should include #8335).

repro:

from typing import Tuple, List, cast

x: List[Tuple[str, str]] = [("a", "b"), ("c", "d")]

c1, c2 = zip(*x) if len(x) > 0 else ([], [])

> $ mypy --version                                       
mypy 0.910
                                                                                              
> $ mypy ~/scratch/test_types.py 
/Users/haroon/scratch/test_types.py:5: error: "builtins.object" object is not iterable
Found 1 error in 1 file (checked 1 source file)

intgr · 2022-03-02T09:42:10Z

@hsghori Please do not report bugs as comments on old bugs, unless you're absolutely certain it's the exact same root cause. And when reporting bugs, ensure that your bug is reproducible in the latest git version, or at least latest release version, of the project.

I cannot reproduce this issue with mypy 0.931

% cat errobject.py
x: list[tuple[str, str]] = [("a", "b"), ("c", "d")]
c1, c2 = zip(*x) if len(x) > 0 else ([], [])
reveal_type(c1)
reveal_type(c2)
% mypy errobject.py
errobject.py:3: note: Revealed type is "typing.Sequence[Any]"
errobject.py:4: note: Revealed type is "typing.Sequence[Any]"

cjolowicz changed the title ~~Type of conditional expressions is object~~ Type of conditional expression is object Dec 4, 2019

JukkaL added false-positive mypy gave an error on correct code needs discussion priority-1-normal topic-union-types labels Dec 4, 2019

calebho mentioned this issue Dec 13, 2019

Mypy doesn't infer enumerate argument properly #8141

Closed

intgr mentioned this issue Jan 26, 2020

Fix joining of Sequence (e.g. variadic tuple) and fixed-length tuple #8335

Merged

intgr mentioned this issue Feb 3, 2020

Type inference of Tuples returns object instead #4975

Closed

emmatyping closed this as completed Feb 3, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Type of conditional expression is object #8074

Type of conditional expression is object #8074

Type of conditional expression is object #8074

Type of conditional expression is object #8074

Comments