8000 Replace `--disallow-any` flags with separate boolean flags. · Issue #4089 · python/mypy · GitHub
[go: up one dir, main page]
Skip to content

Replace --disallow-any flags with separate boolean flags. #4089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
JelleZijlstra opened this issue Oct 10, 2017 · 5 comments
Closed

Replace --disallow-any flags with separate boolean flags. #4089

JelleZijlstra opened this issue Oct 10, 2017 · 5 comments
Labels
topic-usability

Comments

@JelleZijlstra
Copy link
Member

The --disallow-any flags interact in unexpected ways with other flags and they make configuration more complicated. We should replace them with a set of simple boolean flags. See discussion in #4076.
@gvanrossum
Copy link
Member

When we do this, we should get rid of --disallow-any=unannotated completely, since it would just be a synonym for --disallow-untyped-defs.

gvanrossum pushed a commit that referenced this issue Oct 13, 2017
@JelleZijlstra @gvanrossum
Fix config file parsing of disallow_any/disallow_untyped_defs combina…
47e53f8 
…tion (#4076)

Fixes #4075.

There's a follow-up item to just get rid of `--disallow-any=unannotated` completely, but let's do that together with #4089.
@JelleZijlstra
Copy link
Member Author

#4076 already removes unannotated.

@gvanrossum
Copy link
Member

Are you sure? It still looks supported. Maybe you forgot to push a commit?

@JelleZijlstra
Copy link
Member Author

I think you're right. I'll submit another PR with the rest of my changes, probably not now though.

@ilinum
Copy link
Collaborator
ilinum commented Oct 15, 2017 •
edited
Loading

I think it's important that the documentation for the new disallow_any flags is grouped so it is easier to find other disallow_any flags if you're looking at one of them.

@JelleZijlstra I can try to implement this if you want -- it should be pretty straightforward. But if you want to do it -- feel free to.

ilinum added a commit to ilinum/mypy that referenced this issue Oct 29, 2017
@ilinum
Replace --disallow-any flags with separate boolean flags.
03bb9a5 
This PR also gets rid of `--disallow-any=unannotated` because it
is the same thing as `--disallow-untyped-defs`.
Fix python#4089
@ilinum ilinum mentioned this issue Oct 29, 2017
Merged
gvanrossum pushed a commit that referenced this issue Oct 30, 2017
@ilinum @gvanrossum
Replace --disallow-any flags with separate boolean flags. (#4178)
bf90e2c 
This PR also gets rid of `--disallow-any=unannotated` because it
is the same thing as `--disallow-untyped-defs`.
Fix #4089
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
topic-usability
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@JelleZijlstra @gvanrossum @ilinum
0