8000 Regression in mypy 0.930: Cannot override writable attribute "__module__" with a final one · Issue #11820 · python/mypy · GitHub
[go: up one dir, main page]
Skip to content

Regression in mypy 0.930: Cannot override writable attribute "__module__" with a final one #11820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dvarrazzo opened this issue Dec 22, 2021 · 8 comments · Fixed by #11823 or #11945
Closed

Regression in mypy 0.930: Cannot override writable attribute "__module__" with a final one #11820

dvarrazzo opened this issue Dec 22, 2021 · 8 comments · Fixed by #11823 or #11945
Labels
bug mypy got something wrong

Comments

@dvarrazzo
Copy link

Bug Report

The following code is reported as error by mypy 0.930 (Python 3.8). It seems correct, and was considered correct so far:

from enum import Enum

class PyFormat(str, Enum):
    __module__ = "psycopg.adapt"
    AUTO = "s"
    TEXT = "t"
    BINARY = "b"

The error reported is:

$ mypy test_mypy.py 
test_mypy.py:4: error: Cannot override writable attribute "__module__" with a final one  [misc]

which I don't even know what means...
@dvarrazzo dvarrazzo added the bug mypy got something wrong label Dec 22, 2021
@sobolevn
Copy link
Member

Thanks! Fix is on its way. You can add # type: ignore for now.

@dvarrazzo
Copy link
Author

I'm afraid it will have to be "mypy != 0.930" because there are too many of them and because psycopg is also affected by python/typeshed#6661 😄

https://github.com/psycopg/psycopg/runs/4610348714?check_suite_focus=true

@hauntsaninja
Copy link
Collaborator

I'll add pyscopg to mypy_primer, so hopefully you'll have fewer regressions in the future :-)

dvarrazzo added a commit to psycopg/psycopg that referenced this issue Dec 22, 2021
@dvarrazzo
Avoid mypy version 0.930
26cda0b 
The release is affected by the issues:

- python/mypy#11820
- python/typeshed#6661

already acknowledged as bugs.
@dvarrazzo
Copy link
Author

@hauntsaninja amazing, thank you! And thank you all for the quick turnaround!

@sobolevn sobolevn mentioned this issue Dec 22, 2021
Merged
dvarrazzo added a commit to psycopg/psycopg that referenced this issue Dec 23, 2021
@dvarrazzo
Avoid mypy version 0.930
b556720 
The release is affected by the issues:

- python/mypy#11820
- python/typeshed#6661

already acknowledged as bugs.
97littleleaf11 pushed a commit that referenced this issue Dec 30, 2021
@sobolevn
Fixes regression with __module__ and similar non-final Enum names…
b6c8f03 
…, refs #11820 (#11823)
JukkaL pushed a commit that referenced this issue Jan 5, 2022
@sobolevn @JukkaL
Fixes regression with __module__ and similar non-final Enum names…
da6be94 
…, refs #11820 (#11823)
@dvarrazzo
Copy link
Author

This seems still open in mypy 0.931. In which release is the fix due?

https://github.com/psycopg/psycopg/runs/4741795872?check_suite_focus=true

dvarrazzo added a commit to psycopg/psycopg that referenced this issue Jan 7, 2022
@dvarrazzo
Exclude mypy 0.931 too from tests
84f60d1 
It seems still affected by python/mypy#11820.
dvarrazzo added a commit to psycopg/psycopg that referenced this issue Jan 7, 2022
@dvarrazzo
Exclude mypy 0.931 too from tests
bd86d15 
It seems still affected by python/mypy#11820.
@hauntsaninja
Copy link
Collaborator
hauntsaninja commented Jan 7, 2022 •
edited
Loading

The commit made it in, but I don't think it actually fixed the issue (as also evidenced by the lack of a primer diff on that PR). I can still repro on both master and 0.931, cc @sobolevn

@hauntsaninja hauntsaninja reopened this Jan 7, 2022
@hauntsaninja hauntsaninja mentioned this issue Jan 7, 2022
Closed
@sobolevn sobolevn mentioned this issue Jan 9, 2022
Merged
@sobolevn
Copy link
Member
sobolevn commented Jan 9, 2022

I am so sorry 🤦
I've literally confused and and or operations.

Tests didn't catch this, because in tests __module__ is not defined on object.
Now it should be fine! I've double checked it locally.

Снимок экрана 2022-01-09 в 16 01 55

@dvarrazzo
Copy link
Author

No worries, @sobolevn: your work is very appreciated 🙂

97littleleaf11 pushed a commit that referenced this issue Jan 10, 2022
@sobolevn
Fix Enum final props and writable special members, refs #11820 (#11945
f6ebf10 
)
tushar-deepsource pushed a commit to DeepSourceCorp/mypy that referenced this issue Jan 20, 2022
@sobolevn @tushar-deepsource
Fixes regression with __module__ and similar non-final Enum names…
af5f046 
…, refs python#11820 (python#11823)
tushar-deepsource pushed a commit to DeepSourceCorp/mypy that referenced this issue Jan 20, 2022
@sobolevn @tushar-deepsource
Fix Enum final props and writable special members, refs python#11820 (
e7dbc70 
python#11945)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug mypy got something wrong
Projects
None yet
Milestone
No milestone
3 participants
@dvarrazzo @sobolevn @hauntsaninja
0