Suppress untyped defs error in typeshed stubs (#1554)

ddfisher · ddfisher · commit 88b0098a82a1 · 2016-05-19T13:23:22.000-07:00
* Suppress untyped defs error in typeshed stubs

* change name
diff --git a/mypy/checker.py b/mypy/checker.py
@@ -2,6 +2,8 @@
 
 import itertools
 import contextlib
+import os
+import os.path
 
 from typing import (
     Any, Dict, Set, List, cast, Tuple, TypeVar, Union, Optional, NamedTuple
@@ -375,6 +377,7 @@ class TypeChecker(NodeVisitor[Type]):
     disallow_untyped_defs = False
     # Should we check untyped function defs?
     check_untyped_defs = False
+    is_typeshed_stub = False
 
     def __init__(self, errors: Errors, modules: Dict[str, MypyFile],
                  pyversion: Tuple[int, int] = defaults.PYTHON3_VERSION,
@@ -414,6 +417,8 @@ def visit_file(self, file_node: MypyFile, path: str) -> None:
         self.globals = file_node.names
         self.weak_opts = file_node.weak_opts
         self.enter_partial_types()
+        # gross, but no other clear way to tell
+        self.is_typeshed_stub = self.is_stub and 'typeshed' in os.path.normpath(path).split(os.sep)
 
         for d in file_node.defs:
             self.accept(d)
@@ -666,7 +671,7 @@ def check_func_def(self, defn: FuncItem, typ: CallableType, name: str) -> None:
                     self.fail(messages.INIT_MUST_HAVE_NONE_RETURN_TYPE,
                               item.type)
 
-                if self.disallow_untyped_defs:
+                if self.disallow_untyped_defs and not self.is_typeshed_stub:
                     # Check for functions with unspecified/not fully specified types.
                     def is_implicit_any(t: Type) -> bool:
                         return isinstance(t, AnyType) and t.implicit
