Suppress untyped defs error in typeshed stubs #1554
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -375,6 +377,7 @@ class TypeChecker(NodeVisitor[Type]): | |||
| disallow_untyped_defs = False | |||
| # Should we check untyped function defs? | |||
| check_untyped_defs = False | |||
| is_typeshed_file = False | |||
There was a problem hiding this comment.
I'd rename this to is_typeshed_stub.
|
Otherwise LG. |
gvanrossum
pushed a commit
that referenced
this pull request
May 28, 2016
* Suppress untyped defs error in typeshed stubs * change name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See discussion here: python/typeshed#214
The check for if a file is a typeshed file is hackier than I'd like, but it isn't clear to me that there's a better way to do it.