8000 Disable miss-islington comments in check_run as well by ambv · Pull Request #583 · python/miss-islington · GitHub
[go: up one dir, main page]
Skip to content

Disable miss-islington comments in check_run as well #583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 4, 2022
Merged

Disable miss-islington comments in check_run as well #583

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
719cf1c
Disable miss-islington comments in check_run as well
ambv Oct 4, 2022
aeb02ea
No need to list original PR participants for non-automerges (coverage…
ambv Oct 4, 2022
8f88dcb
COVERAGE GODS LEAVE ME ALONE
ambv Oct 4, 2022
cce2f8f
Reformat a little
ambv Oct 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
No need to list original PR participants for non-automerges (coverage… 
… gods)
  • Loading branch information
@ambv
ambv committed Oct 4, 2022
commit aeb02eae22d7333104dc7b5544bc33ecce843c43
13 changes: 7 additions & 6 deletions miss_islington/status_change.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,12 +117,13 @@ async def check_ci_status_and_approval(
if not success:
if is_automerge:
participants = await util.get_gh_participants(gh, pr_number)
else:
original_pr_number = title_match.group("pr")
participants = await util.get_gh_participants(
gh, original_pr_number
)
message = f"{participants}: {message}"
message = f"{participants}: {message}"
# else:
# original_pr_number = title_match.group("pr")
# participants = await util.get_gh_participants(
# gh, original_pr_number
# )
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you elaborate a bit more on the logic here?
When is is_automerge true? When the automerge label is applied to the issue or when the backport PR was approved by a core-dev review? Or both?
And what's the difference between the participants of pr_number and original_pr_number?
IIUC now in case of failure you are pinging the participants of the backport pr -- does that (only?) include whoever merged the backport PR?

(cc @DanielNoord)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I commented out this code because it's no longer covered by tests, i.e. now really only auto-merges should emit comments on PRs.

4FE3
# message = f"{participants}: {message}"
await util.leave_comment(
gh,
pr_number=pr_number,
Expand Down
0